Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark kms self links as computed #1889

Merged

Conversation

chrisst
Copy link
Contributor

@chrisst chrisst commented Jun 5, 2019

Fixes hashicorp/terraform-provider-google#3800

compute: Mark instance KMS self link field `kms_key_self_link` as computed

@chrisst chrisst requested a review from slevenick June 5, 2019 23:06
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 91810579fad1f69f1f1c911ed10ef0eefe558073.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#819
depends: hashicorp/terraform-provider-google#3802

@chrisst chrisst force-pushed the compute-instance-kms-links branch from 9181057 to 0f657fc Compare July 11, 2019 23:27
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 0f657fc.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#937
depends: hashicorp/terraform-provider-google#4007

@modular-magician modular-magician force-pushed the compute-instance-kms-links branch from 0cdc28d to de38cb8 Compare July 11, 2019 23:44
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 0cdc28d.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: modular-magician/ansible#310

chrisst and others added 2 commits July 11, 2019 23:54
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician force-pushed the compute-instance-kms-links branch from de38cb8 to 1eccd48 Compare July 11, 2019 23:54
@modular-magician modular-magician merged commit 5d704d5 into GoogleCloudPlatform:master Jul 11, 2019
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, de38cb8.

Pull request statuses

No diff detected in terraform-google-conversion.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#938
depends: hashicorp/terraform-provider-google#4008

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 1eccd48.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduction of CMEK support for instance causes diff for CMEK referenced disks
5 participants