Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve project after detecting changes #1887

Merged

Conversation

chrisst
Copy link
Contributor

@chrisst chrisst commented Jun 5, 2019

See comment for reasons

fixes hashicorp/terraform-provider-google#2878

@chrisst chrisst requested a review from tysen June 5, 2019 17:13
@chrisst chrisst force-pushed the issue-2878-template-fix branch from 73fbb4e to ec8c00d Compare June 5, 2019 17:22
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 73fbb4eaa867db83e7606d9eadab9f2984e4e793.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#816
depends: hashicorp/terraform-provider-google#3798

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, ec8c00d.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

chrisst and others added 2 commits June 6, 2019 16:20
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician force-pushed the issue-2878-template-fix branch from ec8c00d to dfe7e6f Compare June 6, 2019 16:20
@modular-magician modular-magician merged commit af99ad7 into GoogleCloudPlatform:master Jun 6, 2019
@zaa
Copy link

zaa commented Jun 21, 2019

@chrisst Hey. It looks like the PR does not fully fix the issue. I have a terraform configuration which provisions a google cloud project and then creates a google_compute_instance_template resource using the dynamically generated project id. I use terraform-google-provider v2.9.0, but unfortunately running terraform plan still fails with google_compute_instance_template.<name>: project: required field is not set error.

$ terraform init -upgrade
...
- Downloading plugin for provider "google" (2.9.0)...
- Downloading plugin for provider "google-beta" (2.9.0)...

$ terraform plan

...
Error: Error refreshing state: 1 error occurred:
        * module.hermes-test.google_compute_instance_template.hermes: 1 error occurred:
        * module.hermes-test.google_compute_instance_template.hermes: project: required field is not set
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_compute_instance_template does not work with computed project argument
5 participants