Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for GKE intranode visibility #1871

Merged
merged 2 commits into from
Jun 4, 2019
Merged

Support for GKE intranode visibility #1871

merged 2 commits into from
Jun 4, 2019

Conversation

chrisst
Copy link
Contributor

@chrisst chrisst commented Jun 3, 2019

Also cleaned up some erb syntax

Upstreamed from hashicorp/terraform-provider-google-beta#747

@chrisst chrisst requested review from danawillow and rileykarson and removed request for danawillow June 3, 2019 22:17
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 3c4f1b1c12d6bbed17b72f6be13ff9ca9bce9ae0.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#801
depends: hashicorp/terraform-provider-google#3773

@chrisst chrisst force-pushed the community/intranode-gke branch 3 times, most recently from d806014 to 6f4e1ad Compare June 4, 2019 21:49
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 6f4e1ad.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

1 similar comment
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 6f4e1ad.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@chrisst chrisst force-pushed the community/intranode-gke branch from 6f4e1ad to f25b86e Compare June 4, 2019 22:30
@chrisst
Support for GKE intranode visibility
f59b22d 
Also cleand up some erb syntax
@chrisst chrisst force-pushed the community/intranode-gke branch from f25b86e to f59b22d Compare June 4, 2019 23:37
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, f59b22d.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Update tracked submodules -> HEAD on Tue Jun 4 23:55:43 UTC 2019
b5931f3 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 1ed2b8d into GoogleCloudPlatform:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileykarson rileykarson rileykarson approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisst @modular-magician @rileykarson @googlebot