-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change collection_url_response to a string #1851
Conversation
I'm expecting this will create some PRs as I figure out just how smart ActiveSupport's pluralize method is. |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-provider-google-beta. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-provider-google-beta. New Pull RequestsI didn't open any new pull requests because of this PR. |
The inspec unit tests correctly failed on this! Looks like capitalization issue |
Yep, just sent up a fix! It's a combination of defaults + the capitalization issue. |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-provider-google-beta. New Pull RequestsI didn't open any new pull requests because of this PR. |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-provider-google-beta. New Pull RequestsI didn't open any new pull requests because of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
b0ff1a4
to
aa0270d
Compare
We aren't using the additional information in 'collection_url_response' so let's get rid of it.
Bonus: We can use ActiveSupport's
pluralize
method to make intelligent guesses about most of the list keys.[all]
[terraform]
[terraform-beta]
[ansible]
[inspec]