Fix flattened custom patchable resources #1847
Conversation
| @@ -317,10 +316,6 @@ if <%= props.map { |prop| "d.HasChange(\"#{prop.name.underscore}\")" }.join ' || | |||
| <% end -%> | |||
| obj["<%= prop.api_name -%>"] = <%= prop.api_name -%>Prop | |||
| } | |||
| <% else # if update_body_properties.include? prop -%> | |||
| <%= prop.api_name -%>Prop := d.Get("<%= prop.name.underscore -%>") | |||
There was a problem hiding this comment.
AFAIK this is dead code.
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
templates/terraform/resource.erb
Outdated
| @@ -287,8 +287,7 @@ func resource<%= resource_name -%>Update(d *schema.ResourceData, meta interface{ | |||
| <% properties_by_custom_update(object.root_properties).each do |key, props| -%> | |||
| if <%= props.map { |prop| "d.HasChange(\"#{prop.name.underscore}\")" }.join ' || ' -%> { | |||
| obj := make(map[string]interface{}) | |||
| <% props.each do |prop| -%> | |||
| <% if update_body_properties.include? prop -%> | |||
| <% custom_update_properties_by_url(properties, key[:update_url]).each.each do |prop| -%> | |||
There was a problem hiding this comment.
likewise, the ".each.each"?
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
modular-magician
force-pushed
the
fix-flattened-patches
branch
from
88d0187 to
c8a175b
Compare
[all]
[terraform]
[terraform-beta]
[ansible]
[inspec]