Add fine-grained network endpoint to compute NEGs #1846

emilymye · 2019-05-29T20:09:37Z

Relies on #1845

[all]

[terraform]

Add fine-grained network endpoint to compute NEGs

[terraform-beta]

Add fine-grained network endpoint to compute NEGs

[ansible]

[inspec]

modular-magician · 2019-05-29T20:21:13Z

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 7872da4.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#781
depends: hashicorp/terraform-provider-google#3740

modular-magician · 2019-05-29T21:03:42Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 9ac21d5.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-05-30T03:09:52Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 1b646d8.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-05-30T03:34:05Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, d37697f.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-05-31T02:48:14Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 6ebcbee.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-05-31T20:52:12Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, f60a7e0.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-05-31T20:53:11Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 6a8bf05.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

rileykarson

Generally makes sense, couple nitpicks and a question. Also running the test in CI rn before 👍, I'm just curious about the API.

products/compute/api.yaml

products/compute/terraform.yaml

rileykarson · 2019-06-03T22:03:44Z

third_party/terraform/tests/resource_compute_network_endpoint_test.go.erb

+		Providers: testAccProvidersOiCS,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccComputeNetworkEndpoint_networkEndpointsBasic(context),


Can you add a case before this with multiple NEGs, so we test the mutex & test deleting a single NEG when we move to this step?

nope, not until we get to GA provider tests! If you delete any of them, the next step automatically assumes the resource that was removed from config needs provider "google".

I can add multiple to test the mutex, but honestly I was just gonna add more tests that are actually good once I switch this over to GA provider.

(both NEG and endpoints are in GA API already)

Since we probably want to add a multi-stage test for this regardless of version, should we use the normal acceptance test provider set here so that google is whichever version of the provider we're using?

oh, i misunderstood what testAccProviders/OiCS does - so if I just remove the google-beta blocks it will work and still use the google-beta provider in the test?

Yep! Using the OiCS provider set tests that the google-beta provider is specified on the resources explicitly to make sure the OiCS examples work.

👍 fixed test then

modular-magician · 2019-06-04T17:31:54Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 9ffdd6e.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-06-05T17:38:20Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 57b5ab2.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-06-05T19:02:20Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 064ebb8.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

templates/terraform/examples/network_endpoint.tf.erb

modular-magician · 2019-06-05T20:47:16Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 4e5751d.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-06-05T23:29:47Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, d15836f.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

danawillow · 2019-06-06T16:53:58Z

Removing myself since it looks like Riley already did the review, but feel free to add me back if you'd like an additional opinion

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

googlebot added the cla: yes label May 29, 2019

modular-magician added downstream-generated terraform-provider-google-beta terraform-provider-google labels May 29, 2019

emilymye force-pushed the network_endpoint branch 2 times, most recently from f76f8e6 to 1b646d8 Compare May 30, 2019 02:59

emilymye force-pushed the network_endpoint branch from d37697f to 6ebcbee Compare May 31, 2019 02:36

emilymye force-pushed the network_endpoint branch from 6ebcbee to f60a7e0 Compare May 31, 2019 20:38

emilymye requested a review from danawillow May 31, 2019 20:39

emilymye requested a review from rileykarson June 3, 2019 18:22

rileykarson reviewed Jun 3, 2019

View reviewed changes

products/compute/api.yaml Outdated Show resolved Hide resolved

products/compute/api.yaml Outdated Show resolved Hide resolved

products/compute/api.yaml Outdated Show resolved Hide resolved

products/compute/terraform.yaml Show resolved Hide resolved

rileykarson reviewed Jun 3, 2019

View reviewed changes

rileykarson approved these changes Jun 5, 2019

View reviewed changes

templates/terraform/examples/network_endpoint.tf.erb Show resolved Hide resolved

emilymye force-pushed the network_endpoint branch from 4e5751d to d15836f Compare June 5, 2019 23:19

danawillow removed their request for review June 6, 2019 16:54

modular-magician added the automerged label Jun 6, 2019

add read verb

864fb4f

emilymye and others added 7 commits June 6, 2019 18:06

add network endpoint

57d33ab

+newline

c573857

comments, docs, add another endpoint to text

a5ffff8

remove health check metadata for now

a480ae6

fix test

7da2f15

add provider block to example

713388f

Update tracked submodules -> HEAD on Thu Jun 6 18:06:20 UTC 2019

1026a35

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

modular-magician force-pushed the network_endpoint branch from d15836f to 1026a35 Compare June 6, 2019 18:06

modular-magician merged commit 578b4f9 into GoogleCloudPlatform:master Jun 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add fine-grained network endpoint to compute NEGs #1846

Add fine-grained network endpoint to compute NEGs #1846

emilymye commented May 29, 2019

modular-magician commented May 29, 2019

modular-magician commented May 29, 2019

modular-magician commented May 30, 2019

modular-magician commented May 30, 2019

modular-magician commented May 31, 2019

modular-magician commented May 31, 2019

modular-magician commented May 31, 2019

rileykarson left a comment

rileykarson Jun 3, 2019

emilymye Jun 4, 2019

emilymye Jun 4, 2019

rileykarson Jun 4, 2019

emilymye Jun 5, 2019

rileykarson Jun 5, 2019 •

edited

Loading

emilymye Jun 5, 2019

modular-magician commented Jun 4, 2019

modular-magician commented Jun 5, 2019

modular-magician commented Jun 5, 2019

modular-magician commented Jun 5, 2019

modular-magician commented Jun 5, 2019

danawillow commented Jun 6, 2019

Add fine-grained network endpoint to compute NEGs #1846

Add fine-grained network endpoint to compute NEGs #1846

Conversation

emilymye commented May 29, 2019

[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

modular-magician commented May 29, 2019

Pull request statuses

New Pull Requests

modular-magician commented May 29, 2019

Pull request statuses

New Pull Requests

modular-magician commented May 30, 2019

Pull request statuses

New Pull Requests

modular-magician commented May 30, 2019

Pull request statuses

New Pull Requests

modular-magician commented May 31, 2019

Pull request statuses

New Pull Requests

modular-magician commented May 31, 2019

Pull request statuses

New Pull Requests

modular-magician commented May 31, 2019

Pull request statuses

New Pull Requests

rileykarson left a comment

Choose a reason for hiding this comment

rileykarson Jun 3, 2019

Choose a reason for hiding this comment

emilymye Jun 4, 2019

Choose a reason for hiding this comment

emilymye Jun 4, 2019

Choose a reason for hiding this comment

rileykarson Jun 4, 2019

Choose a reason for hiding this comment

emilymye Jun 5, 2019

Choose a reason for hiding this comment

rileykarson Jun 5, 2019 • edited Loading

Choose a reason for hiding this comment

emilymye Jun 5, 2019

Choose a reason for hiding this comment

modular-magician commented Jun 4, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jun 5, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jun 5, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jun 5, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jun 5, 2019

Pull request statuses

New Pull Requests

danawillow commented Jun 6, 2019

rileykarson Jun 5, 2019 •

edited

Loading