Container Cluster fixes #1794
Container Cluster fixes #1794
Conversation
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-provider-google-beta. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
|
@slevenick This InSpec PR violates the InSpec repo's Rubocop rules. I turned off Rubocop runs during code-generation because I don't think they belong there. |
|
@slevenick - InSpec + Rubocop removal |
| @@ -15,10 +15,6 @@ do | |||
| bundle exec compiler -p $i -e inspec -o "build/inspec/" | |||
| done | |||
|
|
|||
| pushd build/inspec | |||
| rubocop -c .rubocop.yml | |||
There was a problem hiding this comment.
Why are we removing this?
There was a problem hiding this comment.
I removed it in this PR because it was giving errors that was blocking generation (CyclomaticComplexity was too high in generated code).
More broadly, since we're not using this for auto-correction in this step, it seems like it should be moved into inspec-unit-test so it doesn't block generation.
There was a problem hiding this comment.
Ah cyclomatic complexity strikes again. Ok I can add it to the unit test step and modify that rubocop file
There was a problem hiding this comment.
Could you turn off those kinds of rules (CyclomaticComplexity, AbcSize, etc). I don't think they add any value.
The GKE API makes it look like updating initialClusterVersion is the proper way of specifying the Kubernetes API version.
rambleraptor
force-pushed
the
container-options
branch
from
261530a to
50372d5
Compare
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
Addressing ansible/ansible#56426
[all]
[terraform]
[terraform-beta]
[ansible]
[inspec]