Make sure KMS key "deletion" disables rotation

[emilymye]

Fixes hashicorp/terraform-provider-google#3612

Also change some comment styling

---

[all]

[terraform]

Make sure KMS key "deletion" disables rotation

[terraform-beta]

Make sure KMS key "deletion" disables rotation

[ansible]

[inspec]

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 22dbe72.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#705
depends: hashicorp/terraform-provider-google#3624

[chrisst]

Is there any reason somebody would have relied on keys continuing to rotate after deletion? I'm wondering if this needs to be opt it or if it's just further cleaning an inert keyring.
Otherwise 👍

[emilymye]

@chrisst from what I could tell (talking to seth) this was the intended behavior of destroy before, and so it's a bug that we probably shouldn't make a feature. I think if someone is destroying a resource via Terraform, they want to treat the ring like it's been completely deleted/made unusable. We can add a message to the changelog. @paddycarver do you think this counts as a breaking change?

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, e186724.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.