Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TestAccBigQueryTable_ViewWithLegacySQL #1744

Merged
merged 2 commits into from
May 9, 2019

Conversation

danawillow
Copy link
Contributor

At some point BQ must have updated the way they want table names specified in the new sql style syntax, so updating the test to match. I also renamed the test to make it more clear what it's testing, since the _View test already tests only the legacy sql syntax.

$ make testacc TEST=./google TESTARGS='-run=TestAccBigQueryTable_update'
==> Checking source code against gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google -v -run=TestAccBigQueryTable_update -timeout 240m -ldflags="-X=github.com/terraform-providers/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccBigQueryTable_updateView
=== PAUSE TestAccBigQueryTable_updateView
=== CONT  TestAccBigQueryTable_updateView
--- PASS: TestAccBigQueryTable_updateView (5.89s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	6.758s

[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 6d81e10201b693d42492f6dac415db528659c0ef.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#695
depends: hashicorp/terraform-provider-google#3601

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 4154ec9.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@danawillow danawillow requested a review from chrisst May 9, 2019 17:00
danawillow and others added 2 commits May 9, 2019 18:53
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 253b0c4 into GoogleCloudPlatform:master May 9, 2019
@danawillow danawillow deleted the bq-test branch May 9, 2019 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants