Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move AlertPolicy labels to user_labels and make them a map #1685

Merged
merged 4 commits into from
Apr 25, 2019
Merged

Move AlertPolicy labels to user_labels and make them a map #1685

merged 4 commits into from
Apr 25, 2019

Conversation

slevenick
Copy link
Contributor

Move AlertPolicy labels to user_labels and make them a map

[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

@slevenick slevenick force-pushed the alert-policy-user-labels branch from 12bb241 to 12932f7 Compare April 25, 2019 19:55
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 12932f7acf8d2507a361b5d3ad66b654f8fc1414.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#635
depends: GoogleCloudPlatform/terraform-google-conversion#60
depends: hashicorp/terraform-provider-google#3494

@slevenick slevenick requested a review from rileykarson April 25, 2019 20:13
@slevenick slevenick force-pushed the alert-policy-user-labels branch from 12932f7 to d1a747c Compare April 25, 2019 20:30
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 7b1d35a.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Update tracked submodules -> HEAD on Thu Apr 25 21:44:59 UTC 2019
a732cfb 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 78694ff into master Apr 25, 2019
@rileykarson rileykarson mentioned this pull request Apr 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileykarson rileykarson rileykarson approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated terraform-google-conversion terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slevenick @modular-magician @rileykarson @googlebot