Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compute node types and templates #1657

Merged
merged 6 commits into from
Apr 22, 2019
Merged

Add compute node types and templates #1657

merged 6 commits into from
Apr 22, 2019

Conversation

emilymye
Copy link
Contributor

Part 1 of hashicorp/terraform-provider-google#2700

Node groups to follow

[all]

[terraform]

Add compute node types and templates

[terraform-beta]

Add compute node types and templates

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 76bbf97c64ee07b0f3da18d5db131a0818b0bff0.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#614
depends: GoogleCloudPlatform/terraform-google-conversion#55
depends: hashicorp/terraform-provider-google#3446

@emilymye emilymye force-pushed the soletenant branch 2 times, most recently from 7e734f5 to 4a5143f Compare April 18, 2019 20:07
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 4a5143f.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 7a72be3.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

rileykarson
rileykarson approved these changes Apr 22, 2019
View reviewed changes
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a handful of minor things, overall lgtm 👍

products/compute/api.yaml Show resolved Hide resolved
products/compute/terraform.yaml Outdated Show resolved Hide resolved
templates/terraform/examples/node_template_basic.tf.erb Outdated Show resolved Hide resolved
danawillow
danawillow approved these changes Apr 22, 2019
View reviewed changes
Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also a few nits on my end but LGTM

third_party/terraform/tests/data_source_google_compute_node_types_test.go Outdated Show resolved Hide resolved
third_party/terraform/website-compiled/google.erb Show resolved Hide resolved
third_party/terraform/website-compiled/google.erb Outdated Show resolved Hide resolved
third_party/terraform/website/docs/d/google_compute_node_types.html.markdown Outdated Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 114b7e3.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician modular-magician merged commit e2028ff into GoogleCloudPlatform:master Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileykarson rileykarson rileykarson approved these changes

@danawillow danawillow danawillow approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated terraform-google-conversion terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emilymye @modular-magician @danawillow @rileykarson @googlebot