Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terraform: Cloud DNS logging #1598

Merged
merged 2 commits into from
Apr 1, 2019
Merged

Terraform: Cloud DNS logging #1598

merged 2 commits into from
Apr 1, 2019

Conversation

drebes
Copy link
Member

@drebes drebes commented Mar 30, 2019

[all]

[terraform]

[terraform-beta]

Support for Cloud DNS logging policy.

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 4cd8d76.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#573

rileykarson
rileykarson approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @drebes!

@modular-magician
Update tracked submodules -> HEAD on Mon Apr 1 16:58:16 UTC 2019
cd1f8cf 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 5a24edf into GoogleCloudPlatform:master Apr 1, 2019
@drebes drebes deleted the terraform-dns-logging branch March 13, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileykarson rileykarson rileykarson approved these changes

Assignees
No one assigned
Labels
automerged cla: yes community downstream-generated terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drebes @modular-magician @rileykarson @googlebot