Generate BackendService in Terraform #1595

rileykarson · 2019-03-29T22:11:49Z

This was particularly fiddly; specifically, iap has some unusual behaviour that we didn't notice before, security_policy is a bit of an outlier in that it's both post-create + custom update & wasn't made as a fine grained resource, the Go JSON library got confused about a few types, and MM didn't know how to add a default for a float.

[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

modular-magician · 2019-03-29T22:54:29Z

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 6169514.

Pull request statuses

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#569
depends: GoogleCloudPlatform/terraform-google-conversion#39
depends: hashicorp/terraform-provider-google#3345
depends: modular-magician/ansible#222
depends: modular-magician/inspec-gcp#142

modular-magician · 2019-03-29T23:16:46Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, aaf1693.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-04-01T20:51:41Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 628b635.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-04-01T21:42:50Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, bbf9d00.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

third_party/terraform/resources/resource_compute_backend_service_migrate.go

templates/terraform/resource_definition/backend_service.go.erb

templates/terraform/extra_schema_entry/backend_service.erb

templates/terraform/encoders/backend_service.go.erb

chrisst

Once migrate func is cleaned up

modular-magician · 2019-04-02T18:24:01Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 8c6dee6.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-04-02T19:52:20Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, d8bed78.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-04-02T21:15:11Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 7a8110a.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

googlebot added the cla: yes label Mar 29, 2019

rileykarson force-pushed the generate-backend-service branch from a2ba719 to 6169514 Compare March 29, 2019 22:40

modular-magician added downstream-generated ansible inspec terraform-google-conversion terraform-provider-google-beta terraform-provider-google labels Mar 29, 2019

rileykarson requested a review from chrisst April 1, 2019 21:05

rileykarson force-pushed the generate-backend-service branch from 628b635 to bbf9d00 Compare April 1, 2019 21:06

emilymye mentioned this pull request Apr 1, 2019

Signed CDN urls for backend services #1604

Merged

chrisst reviewed Apr 2, 2019

View reviewed changes

chrisst approved these changes Apr 2, 2019

View reviewed changes

rileykarson force-pushed the generate-backend-service branch from 8c6dee6 to d8bed78 Compare April 2, 2019 19:35

modular-magician added the automerged label Apr 2, 2019

rileykarson added 8 commits April 2, 2019 21:36

Generate BackendService at GA

4b64c6e

Add custom request headers to MM

fbe7dfa

Remove handwritten resource map entry

b5d0053

Remove handwritten docs

d29df90

Fix schema

57b1180

Reconcile after rebase

f719d95

Review comments + example

25d75e8

Cast to int again and explain why.

2e8bc13

rileykarson and others added 4 commits April 2, 2019 21:36

Handle negative numbers

fa7d594

Remove unused import

53ea320

Fix minor issues, make tests green.

2414771

Update tracked submodules -> HEAD on Tue Apr 2 21:36:42 UTC 2019

258417b

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

modular-magician force-pushed the generate-backend-service branch from 7a8110a to 258417b Compare April 2, 2019 21:36

modular-magician merged commit 427c133 into GoogleCloudPlatform:master Apr 2, 2019

modular-magician mentioned this pull request Apr 3, 2019

Bug fixes for GCP (as of 2019-04-02T06:06:27+00:00) ansible/ansible#54761

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generate BackendService in Terraform #1595

Generate BackendService in Terraform #1595

rileykarson commented Mar 29, 2019 •

edited

Loading

modular-magician commented Mar 29, 2019

modular-magician commented Mar 29, 2019

modular-magician commented Apr 1, 2019

modular-magician commented Apr 1, 2019

chrisst left a comment

modular-magician commented Apr 2, 2019

modular-magician commented Apr 2, 2019

modular-magician commented Apr 2, 2019

Generate BackendService in Terraform #1595

Generate BackendService in Terraform #1595

Conversation

rileykarson commented Mar 29, 2019 • edited Loading

[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

modular-magician commented Mar 29, 2019

Pull request statuses

New Pull Requests

modular-magician commented Mar 29, 2019

Pull request statuses

New Pull Requests

modular-magician commented Apr 1, 2019

Pull request statuses

New Pull Requests

modular-magician commented Apr 1, 2019

Pull request statuses

New Pull Requests

chrisst left a comment

Choose a reason for hiding this comment

modular-magician commented Apr 2, 2019

Pull request statuses

New Pull Requests

modular-magician commented Apr 2, 2019

Pull request statuses

New Pull Requests

modular-magician commented Apr 2, 2019

Pull request statuses

New Pull Requests

rileykarson commented Mar 29, 2019 •

edited

Loading