Terraform: allow deletion of default route upon network creation

[drebes]

---

[all]

[terraform]

Allow deletion of default route upon network creation

[terraform-beta]

Allow deletion of default route upon network creation

[ansible]

[inspec]

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

[rileykarson]

High-level question: Reading through the use case described in the linked issue, what makes this necessary instead of using a google_compute_route to supersede the default route?

If that's a good enough solution for now, ideally, I'd like to solve this in config and file an issue for a parameter on the upstream API instead of solving it in Terraform. I'm not completely opposed- but implementing features like this in Terraform code has a not-insignificant maintenance cost.

[drebes]

The problem with the default route is that it's not created through the API, but automatically created at network creation time. So a google_compute_route cannot be used to delete it (unless I'm missing something). Not having a default route is a requirement for many enterprise customers (which either want the default route to go to on-prem or to a peered VPC.

[rileykarson]

Right! I'm thinking that this is done by the user, by adding a route whose priority means it'll always be taken over the default route; especially in modules, users can easily accomplish this.

If you're certain that's not acceptable for those users, I'm 👍 on adding the feature, but if it's a universally useful feature, I'd like to try and bring up upstreaming the feature with the product team as well.

[rileykarson]

Made a first pass, unfortunately Terraform isn't great at new fields with defaults so we'll need to coerce it a little.

[rileykarson]

Mostly, yep! We'll never see the field on the resource object so we'll need to pull it from state instead. This suggestion should work if you don't mind verifying.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 6c7069a.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#592
depends: hashicorp/terraform-provider-google#3391

[rileykarson]

Thanks! Looks great.