New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backend bucket signed URL key (for CDN) support #1504

Merged

modular-magician merged 3 commits into GoogleCloudPlatform:master from emilymye:signed_urls

Apr 1, 2019

Contributor

emilymye commented Mar 12, 2019 •

edited

Loading

Also add initial backend services/backend services signed URL key changes but exclude from downstream TF so I can do that in a second PR

[all]

[terraform]

Add backend bucket signed URL key (for CDN) support

[terraform-beta]

Add backend bucket signed URL key (for CDN) support

[ansible]

[inspec]

googlebot added the cla: yes label

emilymye force-pushed the signed_urls branch from 614d059 to 8c7d49b Compare

March 12, 2019 23:58

Collaborator

modular-magician commented Mar 13, 2019

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 8c7d49b02a2c72ed73b3a044ba481a9b1d443071.

Pull request statuses

No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#520
depends: GoogleCloudPlatform/terraform-google-conversion#13
depends: hashicorp/terraform-provider-google#3229
depends: modular-magician/ansible#209

modular-magician added downstream-generated ansible terraform-google-conversion terraform-provider-google-beta terraform-provider-google labels

emilymye mentioned this pull request

Add :exclude_import to Terraform resource properties #1511

Merged

emilymye force-pushed the signed_urls branch from 8c7d49b to ebd76f8 Compare

March 13, 2019 21:46

emilymye requested review from chrisst and rileykarson

March 13, 2019 22:00

Collaborator

modular-magician commented Mar 13, 2019

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, ebd76f8.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: modular-magician/inspec-gcp#127

modular-magician added the inspec label

emilymye requested a review from slevenick

March 13, 2019 22:04

rileykarson reviewed

View reviewed changes

Member

rileykarson left a comment

Just a couple high level questions so far. Since this is a fine-grained resource, I wonder if some of the custom code could be turned into template code; this is a common case and I expect we'll have a handful of very very similar ones (eg network peerings)

products/compute/api.yaml Show resolved Hide resolved

products/compute/terraform.yaml Outdated Show resolved Hide resolved

templates/terraform/decoders/backend_signed_url_key.go.erb Outdated Show resolved Hide resolved

Collaborator

modular-magician commented Mar 13, 2019

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, a5da622.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician added the no-op label

emilymye force-pushed the signed_urls branch 2 times, most recently from 2dd583a to d5033af Compare

March 15, 2019 23:44

emilymye mentioned this pull request

Add "nested decoder" for fine-grained resources #1534

Merged

Collaborator

modular-magician commented Mar 15, 2019

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 2dd583a.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

Collaborator

modular-magician commented Mar 15, 2019

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, d5033af.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

emilymye force-pushed the signed_urls branch 2 times, most recently from 473aeec to 34a2ae0 Compare

March 27, 2019 20:22

Collaborator

modular-magician commented Mar 27, 2019

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 34a2ae0.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

emilymye force-pushed the signed_urls branch from 34a2ae0 to 22b305b Compare

March 27, 2019 21:18

emilymye removed the request for review from slevenick

March 27, 2019 21:22

Collaborator

modular-magician commented Mar 27, 2019

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 22b305b.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

emilymye force-pushed the signed_urls branch from b0abcf9 to 30c1949 Compare

March 27, 2019 22:00

emilymye force-pushed the signed_urls branch 2 times, most recently from 3cbbf7a to cb6f455 Compare

March 28, 2019 17:27

Collaborator

modular-magician commented Mar 28, 2019

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 4288e41.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

emilymye requested a review from rileykarson

March 28, 2019 19:59

emilymye force-pushed the signed_urls branch from 4288e41 to 5efed39 Compare

March 28, 2019 20:04

Collaborator

modular-magician commented Mar 28, 2019

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 5efed39.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

rileykarson approved these changes

View reviewed changes

Member

rileykarson left a comment

LGTM! Thanks for tackling fine-grained resources!

modular-magician added the automerged label

emilymye and others added 3 commits

April 1, 2019 17:45


          add signed url key resource/fields for backend bucket

567211d


          fix missed var rename

0f09de3


          Update tracked submodules -> HEAD on Mon Apr 1 17:45:15 UTC 2019

97ae524

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

modular-magician force-pushed the signed_urls branch from 5efed39 to 97ae524 Compare

April 1, 2019 17:45

modular-magician merged commit 1e62ab6 into GoogleCloudPlatform:master

modular-magician mentioned this pull request

Bug fixes for GCP (as of 2019-04-01T06:05:40+00:00) ansible/ansible#54706

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ansible automerged cla: yes downstream-generated inspec no-op terraform-google-conversion terraform-provider-google terraform-provider-google-beta