Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retention duraction, retain acked message to pubsub #1481

Merged

Conversation

rileykarson
Copy link
Member

@rileykarson rileykarson commented Mar 5, 2019

Fixes hashicorp/terraform-provider-google#2264

/cc @rambleraptor @slevenick this will make downstreams for y'all I think


[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

@rileykarson rileykarson requested a review from chrisst March 5, 2019 17:37
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of f8e4e3f.

Pull request statuses

No diff detected in terraform-google-conversion.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#503
depends: hashicorp/terraform-provider-google#3193
depends: modular-magician/ansible#202
depends: modular-magician/inspec-gcp#121

Copy link
Contributor

@chrisst chrisst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor stuffs

products/pubsub/api.yaml Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, f8e4e3f.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-provider-google already has an open PR.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: GoogleCloudPlatform/terraform-google-conversion#7
depends: modular-magician/ansible#203
depends: modular-magician/inspec-gcp#122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants