Make VPC Native-ness (default) configurable in GKE #1467
Conversation
rileykarson
changed the title
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in Ansible. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
modular-magician
force-pushed
the
vpc-native-gke
branch
from
1a962b9 to
e2c78a9
Compare
| @@ -350,6 +350,11 @@ maintenance_policy { | |||
|
|
|||
| The `ip_allocation_policy` block supports: | |||
|
|
|||
| * `use_ip_aliases` - (Optional) Whether alias IPs will be used for pod IPs in | |||
| the cluster. Defaults to `true` if the `ip_allocation_policy` block is defined, | |||
| and to the API default otherwise. Prior to March 31, 2019, the default on the | |||
There was a problem hiding this comment.
According to emails received today, this change was postponed to June 17th:
From: Google Cloud Platform cloud-proactive-comms+****@google.com
Sent: Monday, March 4, 2019 15:32
Subject: [Reminder] GKE cluster creation default mode will change to VPC-Native from June 17Hello Google Kubernetes Engine Customer,
We previously sent you an email stating that from March 31, 2019, newly created clusters will, by default, be VPC-native instead of routes-based. We are writing to let you know that this change will now take place from June 17, 2019.
[...]
There was a problem hiding this comment.
Thanks! For whatever reason I'm not on the list. I'll update the message.
Fixes hashicorp/terraform-provider-google#2497
The API default is changing upstream at EOM, so we need to allow disabling it before then. We'll adopt the new default early; this isn't a breaking change because of how Terraform computes defaults. Since nested objects are a hack, the
Defaultforuse_ip_aliasesis only used ifip_allocation_policyis defined.We already defaulted to
truewhen the block was defined and adopted the API-sidefalsewhen it was undefined, so this should be compatible with existing configs. It's a non-goal to guard our behaviour to preserve the false-y default; assuming the REST API changes, Terraform users should pick up new best-practice default automatically.[all]
[terraform]
[terraform-beta]
[ansible]
[inspec]