Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set remove_default_node_pool for import if false - fixes TF tests #1465

Merged

Conversation

emilymye
Copy link
Contributor

@emilymye emilymye commented Mar 1, 2019

Related to hashicorp/terraform-provider-google#3146. Change: imported state now will be "" if default node pool exists instead of "false".


[all]

[terraform]

Only set remove_default_node_pool for import if false - fixes TF tests

[terraform-beta]

Only set remove_default_node_pool for import if false - fixes TF tests

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of b25fdff554f171392036030537d4efd94ef82439.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#487
depends: hashicorp/terraform-provider-google#3169

@emilymye emilymye reopened this Mar 1, 2019
@emilymye
Copy link
Contributor Author

emilymye commented Mar 1, 2019

Still running more tests but one without remove_default_node_pool and one with:

--- PASS: TestAccContainerCluster_withMonitoring (791.57s)
PASS
--- PASS: TestAccContainerCluster_withDefaultNodePoolRemoved (576.53s)
PASS

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 14dc015.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 3ba9b06 into GoogleCloudPlatform:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants