Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cloud TPU to Terraform #1360

Merged
merged 2 commits into from
Mar 5, 2019
Merged

Conversation

emilymye
Copy link
Contributor

@emilymye emilymye commented Feb 7, 2019

Add support for TPU nodes (https://cloud.google.com/tpu/docs/reference/rest/)


[all]

[terraform]

Add Cloud TPU Nodes

[terraform-beta]

Add Cloud TPU Nodes

[ansible]

[inspec]

third_party/terraform/utils/config.go.erb Outdated Show resolved Hide resolved
path: 'error'
message: 'message'
parameters:
- !ruby/object:Api::Type::String # TODO: resourceref?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate on why it isn't a resourceref? Probably because the resource in question is under the compute api, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It refers to https://cloud.google.com/tpu/docs/reference/rest/v1/projects.locations, so I just did the same thing redis does (which is this). I can change it, just not sure what I should be doing with it instead.

products/tpu/api.yaml Outdated Show resolved Hide resolved
@rileykarson
Copy link
Member

rileykarson commented Feb 7, 2019

I haven't done a review pass, but is this important for 2.0.0? I'd like to minimise the number of dependency changes from now -> release, so I'd be inclined to hold it until then.

@emilymye
Copy link
Contributor Author

emilymye commented Feb 7, 2019

@rileykarson i'm ok with holding off until after

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd imagine for the build failure we need to update our version of the autogenerated libraries in the provider repos; after that, the Magician will pick them up and vendor the library.

tpu "google.golang.org/api/tpu/v1"
)

type TpuOperationWaiter struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rambleraptor: When this is merged this could be another good candidate for early autogen.

@emilymye emilymye force-pushed the tpu branch 5 times, most recently from 1511740 to 9edf255 Compare March 4, 2019 21:38
@emilymye
Copy link
Contributor Author

emilymye commented Mar 4, 2019

@rileykarson updated with autogen

@rileykarson
Copy link
Member

rileykarson commented Mar 4, 2019

Looks like create-prs failed: https://sunrisecafe.ci.cloud-graphite.com/teams/magic-modules/pipelines/magician/jobs/create-prs/builds/1470

edit: oh nevermind I lied. Missed the second force-push

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 9edf255.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#494
depends: hashicorp/terraform-provider-google#3179

emilymye and others added 2 commits March 5, 2019 00:15
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 25d14de into GoogleCloudPlatform:master Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants