-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cloud TPU to Terraform #1360
Conversation
path: 'error' | ||
message: 'message' | ||
parameters: | ||
- !ruby/object:Api::Type::String # TODO: resourceref? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you elaborate on why it isn't a resourceref? Probably because the resource in question is under the compute api, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It refers to https://cloud.google.com/tpu/docs/reference/rest/v1/projects.locations, so I just did the same thing redis does (which is this). I can change it, just not sure what I should be doing with it instead.
I haven't done a review pass, but is this important for |
@rileykarson i'm ok with holding off until after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd imagine for the build failure we need to update our version of the autogenerated libraries in the provider repos; after that, the Magician will pick them up and vendor the library.
tpu "google.golang.org/api/tpu/v1" | ||
) | ||
|
||
type TpuOperationWaiter struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rambleraptor: When this is merged this could be another good candidate for early autogen.
1511740
to
9edf255
Compare
@rileykarson updated with autogen |
Looks like edit: oh nevermind I lied. Missed the second force-push |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
Add support for TPU nodes (https://cloud.google.com/tpu/docs/reference/rest/)
[all]
[terraform]
Add Cloud TPU Nodes
[terraform-beta]
Add Cloud TPU Nodes
[ansible]
[inspec]