[Terraform] Store SHA 256 of certificate SSL private keys #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should resolve hashicorp/terraform-provider-google#927. Tests pass locally. |
|
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
|
I am a robot that works on MagicModules PRs! Once this PR is approved, you can feel free to merge it without taking any further steps. |
rileykarson
approved these changes
Feb 1, 2019
This updates the SSL certificate keys property to use a custom flatten function, setting it to a hashed value of the key. It also adds a diffSuppressFunc to check the config against the hash.
modular-magician
force-pushed
the
paddy_ssl_keys_out_of_state
branch
from
2c15d55 to
a2371f9
Compare
This was referenced Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than storing the private key in cleartext, this PR changes compute_certificates to store the SSL private key's SHA256 sum, and uses a diffsuppress to ensure that we still get changes when the private key changes.
[all]
[terraform]
SHA256 encode compute_certificate's private keys
[terraform-beta]
[ansible]
[inspec]