Add fields to InterconnectAttachment to allow for PARTNER interconnects

[cblecker]

This is my first magic-modules PR -- Please let me know if there are additional steps I should take.
ref: hashicorp/terraform-provider-google#2942
cc: @ndmckinley

---

[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

[nat-henderson]

Looks great. Let me go ahead and get the downstreams generated and we'll take a look!

[modular-magician]

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#394
depends: hashicorp/terraform-provider-google#2959
depends: modular-magician/ansible#180

[cblecker]

@ndmckinley I actually found another output status field that's needed. Can I just update this PR?

[cblecker]

I reviewed the API spec for the enum fields type and spec, and updated with the full list of options.

[nat-henderson]

Yep, go ahead and update the PR! I'll just have to do a quick review of each successive commit - just a quick glance.

[nat-henderson]

Ah, you see that failure under checks there? Here's the error message.

bundler: failed to load command: compiler (compiler)
Psych::SyntaxError: (<unknown>): did not find expected '-' indicator while parsing a block collection at line 4238 column 7
  /root/.rbenv/versions/2.6.0/lib/ruby/2.6.0/psych.rb:456:in `parse'
  /root/.rbenv/versions/2.6.0/lib/ruby/2.6.0/psych.rb:456:in `parse_stream'
  /root/.rbenv/versions/2.6.0/lib/ruby/2.6.0/psych.rb:390:in `parse'
  /root/.rbenv/versions/2.6.0/lib/ruby/2.6.0/psych.rb:349:in `safe_load'
  /tmp/build/fb9bd761/magic-modules-branched/google/yaml_validator.rb:25:in `parse'
  /tmp/build/fb9bd761/magic-modules-branched/api/compiler.rb:35:in `run'
  compiler:117:in `block in <top (required)>'
  compiler:101:in `each'
  compiler:101:in `<top (required)>'

You should be able to reproduce locally - do you get the same result?

[cblecker]

@ndmckinley Oops! yeah, indentation issue. Fixed and tested locally!

[nat-henderson]

On its way through the pipeline! Watch the status indicators below - should show up under concourse-ci/* - if you see any failures, the "details" link should show you the Concourse CI logs. There's a chance you'll have access issues, but if that happens, let me know.

[modular-magician]

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 8b08ffa) have been included in your existing downstream PRs.

[cblecker]

Everything looks green from here :)

[nat-henderson]

These changes look great to me! I don't have access to an interconnect - could you post the debug logs of creating one of each type of interconnect attachment? If that looks right, I'll approve and this will be out in the next release.

[cblecker]

@ndmckinley I unfortunately don't have a dedicated interconnect either, so I can't set up that type. I have access to a partner interconnect, but can only do the first half of setup for it to go into a pending state, as the second half of setup requires third-party vendor action.

[nat-henderson]

Bummer! Let me go find someone who's got one.

[nat-henderson]

Okay, I do have access to someone who's got access to a dedicated interconnect - if you can test the first part of the partner interconnect, by our powers combined (:globe_with_meridians:), we can merge this change.

[cblecker]

Okay, so I created these two objects:

resource "google_compute_router" "router1" {
  name    = "rooter-1"
  network = "default"

  bgp {
    asn            = 16550
    advertise_mode = "CUSTOM"

    advertised_ip_ranges {
      range = "10.0.0.0/8"
    }
  }
}

resource "google_compute_interconnect_attachment" "vlan1" {
  name                     = "vlan1"
  type                     = "PARTNER"
  router                   = "${google_compute_router.router1.name}"
  edge_availability_domain = "AVAILABILITY_DOMAIN_1"
}

I checked out and compiled hashicorp/terraform-provider-google@75909d7, then used it to terraform apply those two objects.

Debug log is here: https://gist.github.com/cblecker/f7bfe8030d47035a401564f0514d57eb

I've modified the log slightly to substitute the GCP project name, and my google account name from the log.

[nat-henderson]

Looks great! I'll wait for mine to get back to me and we'll see what we can do. Thank you!

[rambleraptor]

(The Ansible downstream looks good to me!)

[nat-henderson]

Okay, almost there! You just need to set type to Optional and Computed, by adding the default_from_api: true flag to terraform.yaml. Then I can merge it.

[cblecker]

@ndmckinley Done!

[modular-magician]

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit dd218ee) have been included in your existing downstream PRs.

[nat-henderson]

Great! Well done, thanks for your contribution.

[cblecker]

Thanks for the help in getting this in!

One last question: Do you happen to know when the next expected cut of the terraform google provider will be?

[nat-henderson]

We're working that out now, but if it's more than 2 weeks from now, I'd be surprised. :)

[cblecker]

Sounds great! Thank you!