Check downstreams to make sure that there aren't any unmerged. #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am a robot that works on MagicModules PRs! Once this PR is approved, you can feel free to merge it without taking any further steps. |
chrisst
approved these changes
Jan 29, 2019
| assert len(sys.argv) == 2 | ||
| unmerged = get_unmerged_prs( | ||
| g, get_downstream_prs.get_github_dependencies( | ||
| g, int(open(sys.argv[1]).read()))) |
There was a problem hiding this comment.
Can you use a local variable or comment so I know what is coming from argv[1] ?
There was a problem hiding this comment.
Haha, thanks.
|
I am a robot that works on MagicModules PRs! Once this PR is approved, you can feel free to merge it without taking any further steps. |
modular-magician
force-pushed
the
check-downstreams
branch
from
ed59a9d to
888f1fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it so that we can't accidentally merge PRs with downstreams still open in the event of a transient GitHub API issue (which seems to happen sometimes). Now, merge-prs will just crash if there are open downstreams.
[all]
CI changes only.
[terraform]
[terraform-beta]
[ansible]
[inspec]