Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Terraform]: Add disable_dependent_services to google_project_service resource. #1283

Conversation

rileykarson
Copy link
Member

@rileykarson rileykarson commented Jan 23, 2019

Fixes hashicorp/terraform-provider-google#2646

Waiting on upstream changes before review/merge. upstream is fixed.


[all]

[terraform]

Add disable_dependent_services to google_project_service resource.

[terraform-beta]

[ansible]

[inspec]

@rileykarson rileykarson force-pushed the disable-dependent-services branch from afa2721 to 3cdfbc2 Compare January 25, 2019 19:34
@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#384
depends: hashicorp/terraform-provider-google#2938

@rileykarson rileykarson changed the title [WIP Terraform]: Add disable_dependent_services to google_project_service resource. Terraform]: Add disable_dependent_services to google_project_service resource. Jan 25, 2019
@rileykarson rileykarson changed the title Terraform]: Add disable_dependent_services to google_project_service resource. [Terraform]: Add disable_dependent_services to google_project_service resource. Jan 25, 2019
@rileykarson rileykarson force-pushed the disable-dependent-services branch from c0e02d8 to 9d34d7b Compare January 28, 2019 19:12
@rileykarson rileykarson requested a review from chrisst January 28, 2019 19:12
@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 52acb76) have been included in your existing downstream PRs.

@modular-magician modular-magician force-pushed the disable-dependent-services branch from 9d34d7b to ad43cb8 Compare January 28, 2019 21:57
@modular-magician modular-magician merged commit 2533e94 into GoogleCloudPlatform:master Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade serviceusage/v1beta1 to serviceusage/v1
4 participants