Welcome external-to-google contributors with a nice message and assignee. #1275
Conversation
| echo > comment/pr_comment << EOF | ||
| Hello! I am a robot who works on Magic Modules PRs. | ||
|
|
||
| I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs. |
There was a problem hiding this comment.
Maybe add a "Thank you for your contribution" somewhere in here?
There was a problem hiding this comment.
Can we say "soon" instead of "within 2 business days". I'd rather beat their expectations (because they weren't expecting us to respond soon), rather than not meet the expectations we place on ourselves.
|
|
||
| EOF | ||
|
|
||
| shuf -n 1 <(printf "ndmckinley\nrambleraptor\nchrisst\nrileykarson\nSirGitsalot\nslevenick") > comment/assignee |
There was a problem hiding this comment.
I'm not a fan of this (we'll forget to update it), but I'm assuming it's unavoidable. Is there a way to get this info from the GitHub API (getting a list of people from a team?)
There was a problem hiding this comment.
Gotta have a list someplace - the Github Graphite team has 42 members and maybe 1 in 5 of them is a regular contributor who checks their github notifications.
|
I am a robot that works on MagicModules PRs! Once this PR is approved, you can feel free to merge it without taking any further steps. |
| echo > comment/pr_comment << EOF | ||
| Hello! I am a robot who works on Magic Modules PRs. | ||
|
|
||
| I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs. |
There was a problem hiding this comment.
Can we say "soon" instead of "within 2 business days". I'd rather beat their expectations (because they weren't expecting us to respond soon), rather than not meet the expectations we place on ourselves.
|
I am a robot that works on MagicModules PRs! Once this PR is approved, you can feel free to merge it without taking any further steps. |
Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
modular-magician
force-pushed
the
magician-users
branch
from
7e5edec to
5c9649a
Compare
Random assignee from a list in a file right now - we could probably make it better, but imo this is good enough when it comes to this sort of thing.
[all]
CI changes only.
[terraform]
[terraform-beta]
[ansible]
[inspec]