Add Azure Event Hubs ingestion fields to google_pubsub_topic

[andreajialee]

Add Azure Event Hubs ingestion fields to google_pubsub_topic

Release Note Template for Downstream PRs (will be copied)

pubsub: added `ingestion_data_source_settings.azure_event_hubs` field to `google_pubsub_topic` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 278 insertions(+))
google-beta provider: Diff ( 3 files changed, 278 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_pubsub_topic (190 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_pubsub_topic" "primary" {
  ingestion_data_source_settings {
    azure_event_hubs {
      client_id           = # value needed
      event_hub           = # value needed
      gcp_service_account = # value needed
      namespace           = # value needed
      resource_group      = # value needed
      subscription_id     = # value needed
      tenant_id           = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 56
Passed tests: 55
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• pubsub

🟢 All tests passed!

View the build log

[zli82016]

To fix the fmt and lint errors

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 278 insertions(+))
google-beta provider: Diff ( 3 files changed, 278 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_pubsub_topic (190 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_pubsub_topic" "primary" {
  ingestion_data_source_settings {
    azure_event_hubs {
      client_id           = # value needed
      event_hub           = # value needed
      gcp_service_account = # value needed
      namespace           = # value needed
      resource_group      = # value needed
      subscription_id     = # value needed
      tenant_id           = # value needed
    }
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 278 insertions(+))
google-beta provider: Diff ( 3 files changed, 278 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_pubsub_topic (190 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_pubsub_topic" "primary" {
  ingestion_data_source_settings {
    azure_event_hubs {
      client_id           = # value needed
      event_hub           = # value needed
      gcp_service_account = # value needed
      namespace           = # value needed
      resource_group      = # value needed
      subscription_id     = # value needed
      tenant_id           = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 56
Passed tests: 55
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• pubsub

🟢 All tests passed!

View the build log

[modular-magician]

Tests analytics

Total tests: 56
Passed tests: 55
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• pubsub

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 278 insertions(+))
google-beta provider: Diff ( 3 files changed, 278 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_pubsub_topic (190 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_pubsub_topic" "primary" {
  ingestion_data_source_settings {
    azure_event_hubs {
      client_id           = # value needed
      event_hub           = # value needed
      gcp_service_account = # value needed
      namespace           = # value needed
      resource_group      = # value needed
      subscription_id     = # value needed
      tenant_id           = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 56
Passed tests: 55
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• pubsub

🟢 All tests passed!

View the build log

[andreajialee]

To fix the fmt and lint errors

Changes are done!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 310 insertions(+))
google-beta provider: Diff ( 3 files changed, 310 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

[modular-magician]

Tests analytics

Total tests: 57
Passed tests: 55
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

• pubsub

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccPubsubTopic_azureEventHubsIngestionUpdate

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccPubsubTopic_azureEventHubsIngestionUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[zli82016]

@andreajialee , is there a Github issue for this PR? Thanks.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 310 insertions(+))
google-beta provider: Diff ( 3 files changed, 310 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

[modular-magician]

Tests analytics

Total tests: 57
Passed tests: 56
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• pubsub

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 382 insertions(+))
google-beta provider: Diff ( 4 files changed, 382 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))

[modular-magician]

Tests analytics

Total tests: 58
Passed tests: 55
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages

• pubsub

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccPubsubTopic_azureEventHubsIngestionUpdate
• TestAccPubsubTopic_pubsubTopicIngestionAzureEventHubsExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccPubsubTopic_azureEventHubsIngestionUpdate [Debug log]
TestAccPubsubTopic_pubsubTopicIngestionAzureEventHubsExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[zli82016]

LGTM