Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAM for Colab runtime template #12742

Open
wants to merge 68 commits into
base: main
Choose a base branch
from

Conversation

bcreddy-gcp
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

colab: Added IAM to `google_colab_runtime_template`.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 731 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 731 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 375 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 6
Passed tests: 3
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • colab

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccColabRuntimeTemplateIamBindingGenerated
  • TestAccColabRuntimeTemplateIamMemberGenerated
  • TestAccColabRuntimeTemplateIamPolicyGenerated

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccColabRuntimeTemplateIamBindingGenerated [Debug log]
TestAccColabRuntimeTemplateIamMemberGenerated [Debug log]
TestAccColabRuntimeTemplateIamPolicyGenerated [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 1088 insertions(+), 682 deletions(-))
google-beta provider: Diff ( 8 files changed, 1088 insertions(+), 672 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 475 insertions(+), 145 deletions(-))
Open in Cloud Shell: Diff ( 2 files changed, 4 insertions(+), 55 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field data_persistent_disk_spec.disk_size_gb within resource google_colab_runtime_template was either removed or renamed - reference
  • Field data_persistent_disk_spec.disk_type within resource google_colab_runtime_template was either removed or renamed - reference
  • Field data_persistent_disk_spec within resource google_colab_runtime_template was either removed or renamed - reference
  • Field description within resource google_colab_runtime_template was either removed or renamed - reference
  • Field effective_labels within resource google_colab_runtime_template was either removed or renamed - reference
  • Field encryption_spec.kms_key_name within resource google_colab_runtime_template was either removed or renamed - reference
  • Field encryption_spec within resource google_colab_runtime_template was either removed or renamed - reference
  • Field euc_config.euc_disabled within resource google_colab_runtime_template was either removed or renamed - reference
  • Field euc_config within resource google_colab_runtime_template was either removed or renamed - reference
  • Field idle_shutdown_config.idle_timeout within resource google_colab_runtime_template was either removed or renamed - reference
  • Field idle_shutdown_config within resource google_colab_runtime_template was either removed or renamed - reference
  • Field labels within resource google_colab_runtime_template was either removed or renamed - reference
  • Field machine_spec.accelerator_count within resource google_colab_runtime_template was either removed or renamed - reference
  • Field machine_spec.accelerator_type within resource google_colab_runtime_template was either removed or renamed - reference
  • Field machine_spec.machine_type within resource google_colab_runtime_template was either removed or renamed - reference
  • Field machine_spec within resource google_colab_runtime_template was either removed or renamed - reference
  • Field network_spec.enable_internet_access within resource google_colab_runtime_template was either removed or renamed - reference
  • Field network_spec.network within resource google_colab_runtime_template was either removed or renamed - reference
  • Field network_spec.subnetwork within resource google_colab_runtime_template was either removed or renamed - reference
  • Field network_spec within resource google_colab_runtime_template was either removed or renamed - reference
  • Field network_tags within resource google_colab_runtime_template was either removed or renamed - reference
  • Field shielded_vm_config.enable_secure_boot within resource google_colab_runtime_template was either removed or renamed - reference
  • Field shielded_vm_config within resource google_colab_runtime_template was either removed or renamed - reference
  • Field terraform_labels within resource google_colab_runtime_template was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template" "primary" {
  runtime_template_config {
    data_disk_config {
      disk_size_gb = # value needed
      disk_type    = # value needed
    }
    description           = # value needed
    enable_euc            = # value needed
    enable_secure_boot    = # value needed
    idle_shutdown_timeout = # value needed
    kms_key               = # value needed
    labels                = # value needed
    machine_config {
      accelerator_count = # value needed
      accelerator_type  = # value needed
      machine_type      = # value needed
    }
    network_config {
      enable_internet_access = # value needed
      network                = # value needed
      subnetwork             = # value needed
    }
    network_tags = # value needed
  }
  runtime_template_id = # value needed
}

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 6
Passed tests: 3
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • colab

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccColabRuntimeTemplateIamBindingGenerated
  • TestAccColabRuntimeTemplateIamMemberGenerated
  • TestAccColabRuntimeTemplateIamPolicyGenerated

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccColabRuntimeTemplateIamBindingGenerated [Error message] [Debug log]
TestAccColabRuntimeTemplateIamMemberGenerated [Error message] [Debug log]
TestAccColabRuntimeTemplateIamPolicyGenerated [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 741 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 741 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 375 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 741 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 741 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 375 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 6
Passed tests: 3
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • colab

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccColabRuntimeTemplateIamBindingGenerated
  • TestAccColabRuntimeTemplateIamMemberGenerated
  • TestAccColabRuntimeTemplateIamPolicyGenerated

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccColabRuntimeTemplateIamBindingGenerated [Error message] [Debug log]
TestAccColabRuntimeTemplateIamMemberGenerated [Error message] [Debug log]
TestAccColabRuntimeTemplateIamPolicyGenerated [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 6
Passed tests: 6
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • colab

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 731 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 731 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 375 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

2 similar comments
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 731 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 731 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 375 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 731 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 731 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 375 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 6
Passed tests: 6
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • colab

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 6
Passed tests: 6
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • colab

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 6
Passed tests: 6
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • colab

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.