Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Router Standard BPS Terraform Beta to GA support #12697

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

akshat-jindal-nit
Copy link
Contributor

@akshat-jindal-nit akshat-jindal-nit commented Jan 7, 2025

b/387318596
Cloud Router Standard BPS Terraform Beta => GA support

Release Note Template for Downstream PRs (will be copied)

compute: promoted `bgp_best_path_selection_mode `,`bgp_bps_always_compare_med` and `bgp_bps_inter_region_cost ` fields in `google_compute_network` from Beta to Ga
compute: promoted `next_hop_origin `,`next_hop_med ` and `next_hop_inter_region_cost ` output fields in `google_compute_route` form Beta to GA

Copy link

github-actions bot commented Jan 7, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from hao-nan-li January 7, 2025 05:10
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 7, 2025
@akshat-jindal-nit akshat-jindal-nit changed the title Best path Cloud Router Standard BPS Terraform Beta to GA support Jan 7, 2025
@modular-magician modular-magician added service/compute-vpc and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 7, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 405 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 4 files changed, 21 insertions(+), 135 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1077
Passed tests: 1004
Skipped tests: 73
Affected tests: 0

Click here to see the affected service packages
  • compute
#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccComputeNetwork_bgpAlwaysCompareMedAndUpdate
  • TestAccComputeNetwork_bgpBestPathSelectionModeAndUpdate
  • TestAccComputeNetwork_bgpInterRegionCostAndUpdate
  • TestAccComputeNetwork_default_bgp_always_compare_med
  • TestAccComputeNetwork_default_bgp_best_path_selection_mode
  • TestAccComputeNetwork_networkBgpBestPathSelectionModeExample
  • TestAccComputeNetwork_networkBgpBestPathSelectionModeStandardCustomFieldsExample
  • TestAccComputeNetwork_networkBgpBestPathSelectionModeStandardExample
    🟢 All tests passed!

View the build log

@hao-nan-li
Copy link
Contributor

Could you update the release note according to https://googlecloudplatform.github.io/magic-modules/code-review/release-notes/? Otherwise LGTM

@akshat-jindal-nit
Copy link
Contributor Author

Could you update the release note according to https://googlecloudplatform.github.io/magic-modules/code-review/release-notes/? Otherwise LGTM

done

@github-actions github-actions bot requested a review from hao-nan-li January 9, 2025 04:16
@hao-nan-li hao-nan-li merged commit 86536e5 into GoogleCloudPlatform:main Jan 9, 2025
19 of 21 checks passed
bcreddy-gcp pushed a commit to bcreddy-gcp/magic-modules that referenced this pull request Jan 13, 2025
bcreddy-gcp pushed a commit to bcreddy-gcp/magic-modules that referenced this pull request Jan 13, 2025
bcreddy-gcp pushed a commit to bcreddy-gcp/magic-modules that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants