Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add health_check and external_endpoints to google_dns_record_set #12682

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

rosmo
Copy link
Contributor

@rosmo rosmo commented Jan 3, 2025

Add support for health_check and external_endpoints which allows implementing this with Terraform: cloud.google.com/load-balancing/docs/https/applb-failover-overview.

I wanted to add exactly-one-of and conflicts but turns out there's no easy way to do that if the parent items aren't MaxItems: 1 (eg. wrr).

dns: added `health_check` and `external_endpoints` fields to `google_dns_record_set` resource

@github-actions github-actions bot requested a review from trodge January 3, 2025 18:12
Copy link

github-actions bot commented Jan 3, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 255 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 3 files changed, 255 insertions(+), 14 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dns_record_set (37 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dns_record_set" "primary" {
  routing_policy {
    geo {
      health_checked_targets {
        external_endpoints = # value needed
      }
    }
    wrr {
      health_checked_targets {
        external_endpoints = # value needed
      }
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 47
Passed tests: 45
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • dns

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDNSRecordSet_routingPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDNSRecordSet_routingPolicy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@rosmo rosmo force-pushed the rrset-new-params branch from 6ca757d to 05701c7 Compare January 3, 2025 18:57
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 305 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 3 files changed, 305 insertions(+), 14 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 47
Passed tests: 45
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • dns

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDNSRecordSet_routingPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDNSRecordSet_routingPolicy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants