-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add health_check and external_endpoints to google_dns_record_set #12682
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_dns_record_set" "primary" {
routing_policy {
geo {
health_checked_targets {
external_endpoints = # value needed
}
}
wrr {
health_checked_targets {
external_endpoints = # value needed
}
}
}
}
|
Tests analyticsTotal tests: 47 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
6ca757d
to
05701c7
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 47 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Add support for
health_check
andexternal_endpoints
which allows implementing this with Terraform: cloud.google.com/load-balancing/docs/https/applb-failover-overview.I wanted to add exactly-one-of and conflicts but turns out there's no easy way to do that if the parent items aren't MaxItems: 1 (eg.
wrr
).