Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parameter manager parameter version resource google_parameter_manager_parameter_version #12641

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

abheda-crest
Copy link
Contributor

Add support for parameter manager parameter version resource google_parameter_manager_parameter_version

More info about parameter manager: https://cloud.google.com/secret-manager/parameter-manager/docs/overview

Note: This PR is dependent upon the parameter manager parameter resource which will be added as a part of the PR #12630

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_parameter_manager_parameter_version`

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 23, 2024
@abheda-crest abheda-crest marked this pull request as ready for review January 13, 2025 06:06
@github-actions github-actions bot requested a review from rileykarson January 13, 2025 06:06
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@abheda-crest
Copy link
Contributor Author

I've attached screenshot for the local test run for the test cases for google_parameter_manager_parameter_version resource:
image

@abheda-crest
Copy link
Contributor Author

@rileykarson Could you please review this PR?

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 13, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 184 insertions(+))
google-beta provider: Diff ( 9 files changed, 1036 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 4
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • parametermanager

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccParameterManagerParameterVersion_parameterVersionBasicExample
  • TestAccParameterManagerParameterVersion_parameterVersionWithJsonFormatExample
  • TestAccParameterManagerParameterVersion_parameterVersionWithYamlFormatExample
  • TestAccParameterManagerParameterVersion_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccParameterManagerParameterVersion_parameterVersionBasicExample [Debug log]
TestAccParameterManagerParameterVersion_parameterVersionWithJsonFormatExample [Debug log]
TestAccParameterManagerParameterVersion_parameterVersionWithYamlFormatExample [Debug log]
TestAccParameterManagerParameterVersion_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

vars:
parameter_id: 'parameter'
parameter_version_id: 'parameter_version'
data: parameter-json-data.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than external data files could we use jsonencode/yamlencode? That's easier to manage the tests for, and easier to use the samples in the docs. file is a Terraform builtin that users should be able to figure out if they do need external definitions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestion. I have updated the examples to use jsonencode/yamlencode for google_parameter_manager_parameter_version resource. Additionally, I have revised the examples for the google_parameter_manager_regional_parameter_version resource that has been merged as a part of the PR #12642.

@github-actions github-actions bot requested a review from rileykarson January 16, 2025 05:57
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 16, 2025
…rameter_data in regional parameter version resource
@abheda-crest
Copy link
Contributor Author

@rileykarson Could you please review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that need reviewer's approval to run presubmit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants