-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for parameter manager parameter version resource google_parameter_manager_parameter_version
#12641
base: main
Are you sure you want to change the base?
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
@rileykarson Could you please review this PR? |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 8 Click here to see the affected service packages
Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
vars: | ||
parameter_id: 'parameter' | ||
parameter_version_id: 'parameter_version' | ||
data: parameter-json-data.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than external data files could we use jsonencode/yamlencode? That's easier to manage the tests for, and easier to use the samples in the docs. file
is a Terraform builtin that users should be able to figure out if they do need external definitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your suggestion. I have updated the examples to use jsonencode/yamlencode for google_parameter_manager_parameter_version
resource. Additionally, I have revised the examples for the google_parameter_manager_regional_parameter_version
resource that has been merged as a part of the PR #12642.
…rameter_data in regional parameter version resource
@rileykarson Could you please review this PR? |
Add support for parameter manager parameter version resource
google_parameter_manager_parameter_version
More info about parameter manager: https://cloud.google.com/secret-manager/parameter-manager/docs/overview
Note: This PR is dependent upon the parameter manager parameter resource which will be added as a part of the PR #12630
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.