Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make contentsDeltaUri optional #12637

Conversation

yutatanamoto
Copy link
Contributor

@yutatanamoto yutatanamoto commented Dec 23, 2024

Summary

Deleted required: true from contentsDeltaUri because it is not required property.

Background

Release Note

vertexai: made `contents_delta_uri` a optional field in `google_vertex_ai_index`

@github-actions github-actions bot requested a review from ScottSuarez December 23, 2024 08:25
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/aiplatform-matching-engine and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Dec 23, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 11 insertions(+), 11 deletions(-))
google-beta provider: Diff ( 2 files changed, 11 insertions(+), 11 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 58
Passed tests: 55
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages
  • vertexai

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants