Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marked RegionNetworkEndpointGroup psc_data as default_from_api #12635

Conversation

shuyama1
Copy link
Member

fixes hashicorp/terraform-provider-google#20576

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: fixed perma-destroy for `psc_data` in `google_compute_region_network_endpoint_group` resource

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+))
google-beta provider: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1077
Passed tests: 1004
Skipped tests: 73
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

@shuyama1
Copy link
Member Author

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample passed on TC

@shuyama1 shuyama1 requested review from a team, zli82016, melinath and roaks3 and removed request for a team, zli82016 and melinath December 20, 2024 23:33
@shuyama1
Copy link
Member Author

/gcbrun to get the new cassette recorded given the test is also updated in #12609

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+))
google-beta provider: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1077
Passed tests: 1004
Skipped tests: 73
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

@shuyama1
Copy link
Member Author

shuyama1 commented Dec 23, 2024

VCR test is running on TC, as the affected test is in a different service package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample
3 participants