CodeRepositoryIndex cascade deletion

[JumiDeluxe]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

gemini: added `force_destroy` field to resource `google_code_repository_index`, enabling deletion of the resource even when it has dependent RepositoryGroups

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 2 files changed, 1 insertion(+), 143 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3
Passed tests: 3
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• gemini

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 2 files changed, 2 insertions(+), 143 deletions(-))

[modular-magician]

Tests analytics

Total tests: 6
Passed tests: 4
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• gemini

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccGeminiCodeRepositoryIndex_update
• TestAccGeminiRepositoryGroup_noBootstrap

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccGeminiCodeRepositoryIndex_update [Debug log]
TestAccGeminiRepositoryGroup_noBootstrap [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[github-actions]

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[NickElliot]

Hi, code LGTM but could you clarify what the "cascade deletion" is doing here so I could make sure the release note wording is what we want to convey for Terraform users? thanks!

[JumiDeluxe]

"Cascade deletion" means that we automatically remove children resources (Repository Groups) upon CRIs deletion.

[github-actions]

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[NickElliot]

Got it, could you add a test case for this functionality?

[JumiDeluxe]

Got it, could you add a test case for this functionality?

Added to CRI tests, the new test tries to remove CRI without removing RG directly in Terraform.
All children resources should be deleted, so we're expecting a new plan.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 3 files changed, 128 insertions(+), 143 deletions(-))

[modular-magician]

Tests analytics

Total tests: 7
Passed tests: 6
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• gemini

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccGeminiCodeRepositoryIndex_delete

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccGeminiCodeRepositoryIndex_delete [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[NickElliot]

thanks for the test! I wanted to make a suggestion though to fly by:

due to that test working the way it did, I realized we could make users make accidental changes to their states when currently they have a protective guard. Would it be preferable to add a virtual field "force_delete" that serves as a flag for sending the obj["force"] = true body during DELETE?

If you have an opinion as the service team member that it shouldn't be an issue, let me know

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+))
google-beta provider: Diff ( 4 files changed, 157 insertions(+), 143 deletions(-))

[modular-magician]

Tests analytics

Total tests: 7
Passed tests: 4
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

• gemini

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccGeminiCodeRepositoryIndex_delete
• TestAccGeminiCodeRepositoryIndex_update
• TestAccGeminiRepositoryGroup_noBootstrap

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+))
google-beta provider: Diff ( 4 files changed, 157 insertions(+), 143 deletions(-))

[modular-magician]

Tests analytics

Total tests: 7
Passed tests: 4
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

• gemini

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccGeminiCodeRepositoryIndex_delete
• TestAccGeminiCodeRepositoryIndex_update
• TestAccGeminiRepositoryGroup_noBootstrap

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccGeminiCodeRepositoryIndex_update [Debug log]
TestAccGeminiRepositoryGroup_noBootstrap [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccGeminiCodeRepositoryIndex_delete [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccGeminiRepositoryGroup_noBootstrap [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccGeminiCodeRepositoryIndex_delete [Error message] [Debug log]
TestAccGeminiCodeRepositoryIndex_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+))
google-beta provider: Diff ( 4 files changed, 155 insertions(+), 143 deletions(-))

[modular-magician]

Tests analytics

Total tests: 7
Passed tests: 6
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• gemini

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccGeminiCodeRepositoryIndex_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccGeminiCodeRepositoryIndex_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[NickElliot]

LGTM!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.