Add edgenetwork Router resource. #12594
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
modular-magician
added
the
awaiting-approval
|
@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 1 week. Please take a look! Use the label |
mmv1/templates/terraform/examples/edgenetwork_router_minimal.tf.tmpl
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,82 @@ | |||
|
|
|||
| resource "google_edgenetwork_router" "{{$.PrimaryResourceId}}" { | |||
There was a problem hiding this comment.
It looks like the Router resource is not marked as immutable, and a number of resources are therefore presumed to be mutable in-place. If that's the case, this resource will need an update test to verify that those fields can be updated.
There was a problem hiding this comment.
Can we make an exception and skip this requirement? Due to the dependence on physical hardware, the edgenetwork API can only be tested manually by the internal dev team anyway, so I don't think those sorts of unit tests are useful in this case.
There was a problem hiding this comment.
Would it be possible to write the test but have it be skipped, so that your team can run it as a one off prior to submission?
I understand the constraints will be difficult to work around, but conversely, this resource implementation could be broken and we would have no way of knowing until customers use it. If you have some other way to validate the correct mutability properties for each of these fields perhaps we could rely on that, but otherwise I think we want to at least see output from a passing test before submitting.
|
@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
| type: KeyValueLabels | ||
| description: | | ||
| Labels associated with this resource. | ||
| required: false |
There was a problem hiding this comment.
Nit: I'm still seeing a lot of required: false which is creating some noise when reading
Create Router resource in product edgenetwork.
Fixes hashicorp/terraform-provider-google#15666
Tests are disabled for this resource for the same reason as other resources in
edgenetwork. See: #8905This PR depends on another in-review PR: #12586
Release Note Template for Downstream PRs (will be copied)