Fix service_attachment.target_service validation

[Samir-Cit]

Hello folks.
This PR is to add back the validation of the resource that was removed on this other PR: #11107

Buganizer

The resource now accepts ForwardingRules and Gateways so this validation, that used to have, needed to change to accept both kind of resources.

Note: This PR includes a small refactoring on the test

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: add back the validation for `target_service` field on the `google_compute_service_attachment` resource to validade a `ForwardingRule` or `Gateway` URL.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 13 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 13 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[SirGitsalot]

Looks good, just a couple of nits. Thanks!

[modular-magician]

Tests analytics

Total tests: 1076
Passed tests: 1002
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeServiceAttachment_serviceAttachmentBasicExampleGateway

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleGateway [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 16 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 16 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 13 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1076
Passed tests: 1003
Skipped tests: 73
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log