Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Etag support for ACM service perimeters" #12568

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

coder-221
Copy link
Member

@coder-221 coder-221 commented Dec 13, 2024

Reverts #12363

Unfortunately, we'd like to revert this change and then try again probably in early January with a new approach for perimeter etags. We have ideas on this but for now we think reverting this change will ensure customers upgrading to the next released version aren't broken.

The broken scenario is when there are perimeters from the same policy in separate google_access_context_manager_service_perimeter resources. Customers with multiple perimeters in a single google_access_context_manager_service_perimeters resource would be fine.

Currently, perimeter etags are generated at the policy level (the parent entity). So, when the first PATCH request is sent for updating perimeter 1, then the etag saved in the Terraform plan for the other perimeters is no longer valid. Those updates will fail.

accesscontextmanager: added `etag` to `google_access_context_manager_service_perimeter` and `google_access_context_manager_service_perimeters` (reverts)

@coder-221 coder-221 marked this pull request as ready for review December 13, 2024 18:45
@github-actions github-actions bot requested a review from c2thorn December 13, 2024 18:45
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 74 deletions(-))
google-beta provider: Diff ( 5 files changed, 74 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 21 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field etag within resource google_access_context_manager_service_perimeter was either removed or renamed - reference
  • Field service_perimeters.etag within resource google_access_context_manager_service_perimeters was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3
Passed tests: 2
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • accesscontextmanager

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got approval for the breaking change offline and confirmed this is a standard revert of #12363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
override-breaking-change Allows a potential breaking change to be merged service/accesscontextmanager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants