-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Etag support for ACM service perimeters" #12568
Revert "Etag support for ACM service perimeters" #12568
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. |
Tests analyticsTotal tests: 3 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got approval for the breaking change offline and confirmed this is a standard revert of #12363
Reverts #12363
Unfortunately, we'd like to revert this change and then try again probably in early January with a new approach for perimeter etags. We have ideas on this but for now we think reverting this change will ensure customers upgrading to the next released version aren't broken.
The broken scenario is when there are perimeters from the same policy in separate google_access_context_manager_service_perimeter resources. Customers with multiple perimeters in a single google_access_context_manager_service_perimeters resource would be fine.
Currently, perimeter etags are generated at the policy level (the parent entity). So, when the first PATCH request is sent for updating perimeter 1, then the etag saved in the Terraform plan for the other perimeters is no longer valid. Those updates will fail.