Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add headers to Hosting Version #12527

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Conversation

rainshen49
Copy link
Contributor

@rainshen49 rainshen49 commented Dec 9, 2024

Fixes hashicorp/terraform-provider-google#20527

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

firebasehosting: added `headers` field in `google_firebase_hosting_version` resource (beta)

Copy link

github-actions bot commented Dec 9, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from zli82016 December 9, 2024 20:52
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 50 insertions(+))
google-beta provider: Diff ( 3 files changed, 233 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 62 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_firebase_hosting_version (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_firebase_hosting_version" "primary" {
  config {
    headers {
      regex = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 19
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • firebasehosting

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccFirebaseHostingVersion_firebasehostingVersionHeadersExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccFirebaseHostingVersion_firebasehostingVersionHeadersExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 50 insertions(+))
google-beta provider: Diff ( 3 files changed, 233 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 62 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_firebase_hosting_version (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_firebase_hosting_version" "primary" {
  config {
    headers {
      regex = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 20
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • firebasehosting

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 51 insertions(+))
google-beta provider: Diff ( 3 files changed, 235 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 62 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_firebase_hosting_version (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_firebase_hosting_version" "primary" {
  config {
    headers {
      glob = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 19
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • firebasehosting

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccFirebaseHostingVersion_firebasehostingVersionHeadersExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccFirebaseHostingVersion_firebasehostingVersionHeadersExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 51 insertions(+))
google-beta provider: Diff ( 3 files changed, 235 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 62 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_firebase_hosting_version (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_firebase_hosting_version" "primary" {
  config {
    headers {
      regex = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 19
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • firebasehosting

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccFirebaseHostingVersion_firebasehostingVersionHeadersExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccFirebaseHostingVersion_firebasehostingVersionHeadersExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

mmv1/products/firebasehosting/Version.yaml Outdated Show resolved Hide resolved
mmv1/products/firebasehosting/Version.yaml Outdated Show resolved Hide resolved
mmv1/products/firebasehosting/Version.yaml Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 82 insertions(+))
google-beta provider: Diff ( 3 files changed, 322 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 62 insertions(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 82 insertions(+))
google-beta provider: Diff ( 3 files changed, 322 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 62 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 21
Passed tests: 20
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • firebasehosting

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccFirebaseHostingVersion_firebasehostingVersionHeadersRegexExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccFirebaseHostingVersion_firebasehostingVersionHeadersRegexExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 21
Passed tests: 20
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • firebasehosting

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccFirebaseHostingVersion_firebasehostingVersionHeadersRegexExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccFirebaseHostingVersion_firebasehostingVersionHeadersRegexExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 82 insertions(+))
google-beta provider: Diff ( 3 files changed, 344 insertions(+), 31 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 62 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 21
Passed tests: 21
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • firebasehosting

🟢 All tests passed!

View the build log

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zli82016
Copy link
Member

@tylerg-dev , can you review this PR when you have time? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add headers to the firebase hosting version config
4 participants