Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs for singleton best practices and exclude_delete #12489

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

melinath
Copy link
Member

@melinath melinath commented Dec 4, 2024

Added docs for singleton resources and exclude_delete.

Fixed hashicorp/terraform-provider-google#20486
Fixed hashicorp/terraform-provider-google#20564

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@melinath melinath requested a review from rileykarson December 4, 2024 18:46
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Errors

google provider:

  • Failed to clone repo at new branch
  • Failed to clone repo at old branch

google-beta provider:

  • Failed to clone repo at new branch
  • Failed to clone repo at old branch

terraform-google-conversion:

  • Failed to clone repo at new branch
  • Failed to clone repo at old branch

Open in Cloud Shell:

  • Failed to clone repo at new branch
  • Failed to clone repo at old branch

Other:

  • Failed to fetch PR data

@melinath
Copy link
Member Author

melinath commented Dec 4, 2024

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document singleton best practices Document how to use exclude_delete property
3 participants