-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compute: added subnetwork_id
to compute subnet data source
#12461
compute: added subnetwork_id
to compute subnet data source
#12461
Conversation
Added `subnetwork_id` to `google_compute_subnetwork` data source Picked from GoogleCloudPlatform#12285 Followup to GoogleCloudPlatform#12351 Related to hashicorp/terraform-provider-google#20223
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
Tests analyticsTotal tests: 1071 Click here to see the affected service packages
🟢 All tests passed! View the build log |
@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Added
subnetwork_id
togoogle_compute_subnetwork
data sourcePicked from #12285 (comment here)
Followup to #12351
Related to hashicorp/terraform-provider-google#20223
Related to hashicorp/terraform-provider-google#20530
Release Note Template for Downstream PRs (will be copied)