Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute: added subnetwork_id to compute subnet data source #12461

Conversation

wyardley
Copy link
Contributor

@wyardley wyardley commented Dec 2, 2024

Added subnetwork_id to google_compute_subnetwork data source

Picked from #12285 (comment here)
Followup to #12351
Related to hashicorp/terraform-provider-google#20223
Related to hashicorp/terraform-provider-google#20530

Release Note Template for Downstream PRs (will be copied)

compute: added `subnetwork_id` to `google_compute_subnetwork` data source

Added `subnetwork_id` to `google_compute_subnetwork` data source

Picked from GoogleCloudPlatform#12285
Followup to GoogleCloudPlatform#12351
Related to hashicorp/terraform-provider-google#20223
@github-actions github-actions bot requested a review from NickElliot December 2, 2024 04:23
Copy link

github-actions bot commented Dec 2, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Dec 2, 2024
Copy link

github-actions bot commented Dec 5, 2024

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician added service/compute-vpc and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Dec 5, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 11 insertions(+))
google-beta provider: Diff ( 3 files changed, 11 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1071
Passed tests: 998
Skipped tests: 73
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

Copy link

github-actions bot commented Dec 9, 2024

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants