Add advanced_machine_features.enable_uefi_networking field to instance and templates

[karolgorc]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: `google_compute_instance`, `google_compute_instance_template`, `google_compute_region_instance_template` now supports `advanced_machine_features.enable_uefi_networking` field

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 219 insertions(+))
google-beta provider: Diff ( 10 files changed, 219 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 2 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  advanced_machine_features {
    enable_nested_virtualization = # value needed
    enable_uefi_networking       = # value needed
    performance_monitoring_unit  = # value needed
    threads_per_core             = # value needed
    turbo_mode                   = # value needed
    visible_core_count           = # value needed
  }
}

Resource: google_compute_instance_from_template (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  advanced_machine_features {
    enable_nested_virtualization = # value needed
    enable_uefi_networking       = # value needed
    performance_monitoring_unit  = # value needed
    threads_per_core             = # value needed
    turbo_mode                   = # value needed
    visible_core_count           = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 1067
Passed tests: 991
Skipped tests: 73
Affected tests: 3

Click here to see the affected service packages

• compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInstanceTemplate_enableUefiNetworking
• TestAccComputeInstance_enableUefiNetworking
• TestAccComputeRegionInstanceTemplate_enableUefiNetworking

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeInstanceTemplate_enableUefiNetworking [Debug log]
TestAccComputeInstance_enableUefiNetworking [Debug log]
TestAccComputeRegionInstanceTemplate_enableUefiNetworking [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[github-actions]

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.