Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add negative tests for nonexistent resources #1233

Merged
merged 2 commits into from
Jan 14, 2019

Conversation

slevenick
Copy link
Contributor

Add negative tests for nonexistent resources


[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: modular-magician/inspec-gcp#66

Copy link
Contributor

@rambleraptor rambleraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to autogenerate this? These 4 changes are all handwritten (and bound to be forgotten on some resource down the line).

@slevenick
Copy link
Contributor Author

Is there a way to autogenerate this? These 4 changes are all handwritten (and bound to be forgotten on some resource down the line).

I'm not really sure how to do this well. There are several different HTTP responses that can cause a resource to "not exist", IE 403, 404. I guess I need to clarify what exists? represents in the case of unauthorized

@rambleraptor
Copy link
Contributor

I'm just looking at the 4 things that you typed up here and all of them seemed like they were the same (besides name changes).

slevenick and others added 2 commits January 14, 2019 20:57
Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 5c73a5a into master Jan 14, 2019
@slevenick slevenick deleted the inspec-exists-checks branch April 15, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants