Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made google_container_cluster.user_managed_keys_config not settable and fixed diff due to server-set values #12309

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

melinath
Copy link
Member

@melinath melinath commented Nov 12, 2024

Fixes hashicorp/terraform-provider-google#20301

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: fixed diff on `google_container_cluster.user_managed_keys_config` field for resources that had not set it. (patch release)
container: marked `google_container_cluster.user_managed_keys_config` as immutable because it can't be updated in place. (patch release)

@melinath melinath requested review from a team and slevenick and removed request for a team November 12, 2024 20:30
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 173 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 2 files changed, 172 insertions(+), 14 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 214
Passed tests: 201
Skipped tests: 12
Affected tests: 1

Click here to see the affected service packages
  • container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerCluster_withFleetConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccContainerCluster_withFleetConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@melinath melinath requested a review from ahmedtd November 12, 2024 21:52
@melinath
Copy link
Member Author

melinath commented Nov 12, 2024

@melinath melinath merged commit 9a45aa9 into GoogleCloudPlatform:main Nov 12, 2024
17 of 18 checks passed
@melinath melinath deleted the tpg-20301 branch November 12, 2024 23:10
Gridasov pushed a commit to Gridasov/magic-modules that referenced this pull request Nov 13, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
zeleena pushed a commit to zeleena/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_container_cluster fails with an API error on 6.11.0
4 participants