Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status tag for tracking autogen-created resources #12293

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

slevenick
Copy link
Contributor

Used for tracking purposes, no actual use yet
Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@slevenick slevenick requested a review from c2thorn November 11, 2024 13:40
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we going to add a check for this in main.go? We could keep all of the AutogenStatus's found as we iterate through the resources and flag for duplicates

@slevenick
Copy link
Contributor Author

are we going to add a check for this in main.go? We could keep all of the AutogenStatus's found as we iterate through the resources and flag for duplicates

I see the checking as something we can add in the future. Adding this tag is enough for now as we can check them against the resource name when we count everything up (and see any copy/pastes)

@slevenick slevenick merged commit 12341a5 into GoogleCloudPlatform:main Nov 11, 2024
11 checks passed
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
zeleena pushed a commit to zeleena/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants