-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gke_hub as part of the DCL endpoints #12287
Remove gke_hub as part of the DCL endpoints #12287
Conversation
Tests analyticsTotal tests: 4285 Click here to see the affected service packages
Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
@roaks3 Looks like this change didn't really affect any of the existing test for gkehub, maybe this is not the root cause. Can we still merge it since this line is no longer being used and could potentially cause confusion? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, but might want to remove the fixes:
from the description if this doesn't fully resolve that issue.
Good point, will take that part off. |
On a second thought, this might be the right fix, since the VCR runs on beta and removing this line doesn't affect anything because everything was already running in beta. I'll check in the nightly runs and see if this fixed the issue. |
part of hashicorp/terraform-provider-google#20246
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.