Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gke_hub as part of the DCL endpoints #12287

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

hao-nan-li
Copy link
Contributor

@hao-nan-li hao-nan-li commented Nov 8, 2024

part of hashicorp/terraform-provider-google#20246

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4285
Passed tests: 3866
Skipped tests: 413
Affected tests: 6

Click here to see the affected service packages

All service packages are affected

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupPlanAssociation_backupDrBpaExample
  • TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample
  • TestAccBackupDRBackupVault_fullUpdate
  • TestAccContainerCluster_resourceManagerTags
  • TestAccContainerCluster_withFleetConfig
  • TestAccDataSourceGoogleBackupDRBackupPlanAssociation_basic

Get to know how VCR tests work

@hao-nan-li hao-nan-li marked this pull request as ready for review November 8, 2024 23:03
@hao-nan-li hao-nan-li requested a review from roaks3 November 8, 2024 23:03
@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupPlanAssociation_backupDrBpaExample [Debug log]
TestAccBackupDRBackupVault_fullUpdate [Debug log]
TestAccContainerCluster_resourceManagerTags [Debug log]
TestAccDataSourceGoogleBackupDRBackupPlanAssociation_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContainerCluster_resourceManagerTags [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample [Error message] [Debug log]
TestAccContainerCluster_withFleetConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@hao-nan-li
Copy link
Contributor Author

@roaks3 Looks like this change didn't really affect any of the existing test for gkehub, maybe this is not the root cause. Can we still merge it since this line is no longer being used and could potentially cause confusion?

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, but might want to remove the fixes: from the description if this doesn't fully resolve that issue.

@hao-nan-li
Copy link
Contributor Author

Sounds good, but might want to remove the fixes: from the description if this doesn't fully resolve that issue.

Good point, will take that part off.

@hao-nan-li hao-nan-li merged commit 4e161c2 into GoogleCloudPlatform:main Nov 11, 2024
13 of 14 checks passed
@hao-nan-li
Copy link
Contributor Author

Sounds good, but might want to remove the fixes: from the description if this doesn't fully resolve that issue.

Good point, will take that part off.

On a second thought, this might be the right fix, since the VCR runs on beta and removing this line doesn't affect anything because everything was already running in beta. I'll check in the nightly runs and see if this fixed the issue.

akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
zeleena pushed a commit to zeleena/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants