Updated typos

[wyardley]

Can break these up differently if desired. These resolve downstream golangci-lint misspelling warnings.
Almost all the changes are in docs or function naming only. There are one or two actual fixes (I think) of real enum values, in particular the one in mmv1/products/gkehub2/Feature.yaml (I added a release note for this one, since that's actually fixing something).

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

gkehub: fixed allowable value `INSTALLATION_UNSPECIFIED` in `template_library.installation`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[github-actions]

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 51 files changed, 109 insertions(+), 109 deletions(-))
google-beta provider: Diff ( 51 files changed, 109 insertions(+), 109 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 6 insertions(+), 6 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_privateca_certificate_authority (34 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_privateca_certificate_authority" "primary" {
  config {
    subject_key_id {
      key_id = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 4289
Passed tests: 3876
Skipped tests: 410
Affected tests: 3

Click here to see the affected service packages

All service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample
• TestAccContainerCluster_withFleetConfig
• TestAccStorageBucket_AutoclassDiffSuppress

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccStorageBucket_AutoclassDiffSuppress [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample [Error message] [Debug log]
TestAccContainerCluster_withFleetConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[wyardley]

Second failure seems to be unrelated, tracked in hashicorp/terraform-provider-google#20253. I don't think TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample is related to anything changed here?

[wyardley]

TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample (beta only, I think) seems to work for me locally with or without these changes.

[wyardley]

@BBBmau would you mind running the tests over again? Hopefully #12307 helps with the fleet one, and maybe the other one is flaky, unless you're seeing anything unusual in the failure log for that one? Seems to work for me locally with these changes in both recording and replaying mode.

[BBBmau]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 51 files changed, 109 insertions(+), 109 deletions(-))
google-beta provider: Diff ( 51 files changed, 109 insertions(+), 109 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 6 insertions(+), 6 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_privateca_certificate_authority (34 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_privateca_certificate_authority" "primary" {
  config {
    subject_key_id {
      key_id = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 4292
Passed tests: 3879
Skipped tests: 410
Affected tests: 3

Click here to see the affected service packages

All service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample
• TestAccBackupDRBackupVault_fullUpdate
• TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupVault_fullUpdate [Debug log]
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[wyardley]

@BBBmau can you share the error from the CI run of TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample, and do you think it's related?

Tried a few more times locally in recording and replaying mode (with the changes from this PR, including building for all products vs. just backupdr) and still can't reproduce the failure.

[github-actions]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[wyardley]

@BBBmau I rebased it, and also added one more tiny fix (in a separate commit) that I noticed elsewhere.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 51 files changed, 109 insertions(+), 109 deletions(-))
google-beta provider: Diff ( 51 files changed, 109 insertions(+), 109 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 6 insertions(+), 6 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_privateca_certificate_authority (34 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_privateca_certificate_authority" "primary" {
  config {
    subject_key_id {
      key_id = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 4326
Passed tests: 3912
Skipped tests: 405
Affected tests: 9

Click here to see the affected service packages

All service packages are affected

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataSourceGoogleQuotaInfo_basic
• TestAccOracleDatabaseAutonomousDatabase_basic
• TestAccOracleDatabaseAutonomousDatabases_basic
• TestAccOracleDatabaseCloudExadataInfrastructure_basic
• TestAccOracleDatabaseCloudExadataInfrastructures_basic
• TestAccOracleDatabaseCloudVmCluster_basic
• TestAccOracleDatabaseDbNodes_basic
• TestAccOracleDatabaseDbServers_basic
• TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccOracleDatabaseAutonomousDatabase_basic [Error message] [Debug log]
TestAccOracleDatabaseAutonomousDatabases_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructure_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructures_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudVmCluster_basic [Error message] [Debug log]
TestAccOracleDatabaseDbNodes_basic [Error message] [Debug log]
TestAccOracleDatabaseDbServers_basic [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[BBBmau]

can you rebase once more? We look to be getting some conflicts

[wyardley]

@BBBmau Rebased. Looks like just mmv1/third_party/terraform/fwprovider/framework_validators_test.go being removed upstream.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 50 files changed, 108 insertions(+), 108 deletions(-))
google-beta provider: Diff ( 50 files changed, 108 insertions(+), 108 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 6 insertions(+), 6 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_privateca_certificate_authority (34 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_privateca_certificate_authority" "primary" {
  config {
    subject_key_id {
      key_id = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 4338
Passed tests: 3918
Skipped tests: 405
Affected tests: 15

Click here to see the affected service packages

All service packages are affected

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataSourceGoogleQuotaInfo_basic
• TestAccEphemeralServiceAccountIdToken_basic
• TestAccEphemeralServiceAccountIdToken_withDelegates
• TestAccEphemeralServiceAccountIdToken_withEmptyDelegates
• TestAccEphemeralServiceAccountIdToken_withIncludeEmail
• TestAccEphemeralServiceAccountJwt_basic
• TestAccEphemeralServiceAccountJwt_withDelegates
• TestAccEphemeralServiceAccountJwt_withExpiresIn
• TestAccEphemeralServiceAccountKey_basic
• TestAccEphemeralServiceAccountToken_basic
• TestAccEphemeralServiceAccountToken_withCustomLifetime
• TestAccEphemeralServiceAccountToken_withDelegates
• TestAccOracleDatabaseCloudExadataInfrastructure_basic
• TestAccOracleDatabaseDbServers_basic
• TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountIdToken_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountIdToken_withDelegates [Error message] [Debug log]
TestAccEphemeralServiceAccountIdToken_withEmptyDelegates [Error message] [Debug log]
TestAccEphemeralServiceAccountIdToken_withIncludeEmail [Error message] [Debug log]
TestAccEphemeralServiceAccountJwt_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountJwt_withDelegates [Error message] [Debug log]
TestAccEphemeralServiceAccountJwt_withExpiresIn [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountToken_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountToken_withCustomLifetime [Error message] [Debug log]
TestAccEphemeralServiceAccountToken_withDelegates [Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructure_basic [Error message] [Debug log]
TestAccOracleDatabaseDbServers_basic [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[BBBmau]

tests can be ignored. Thanks for this!