Add IDPF support for the google_compute_instance and google_compute_image.guest_os_features

[Asiderr]

closes: hashicorp/terraform-provider-google#19671

This patch adds IDPF as an possible value of the nic_type in the google_compute_instance and adds IDPF tag to the list of guestOsFeatures in the google_compute_image.

compute: Added the `IDPF` tag to the list of `guestOsFeatures`

compute: Added `IDPF` as a possible `nic_type` for the `google_compute_instance.network_interface`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 13 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 5 files changed, 13 insertions(+), 6 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  network_interface {
    nic_type = # value needed
  }
}

Resource: google_compute_instance_from_template (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  network_interface {
    nic_type = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 1059
Passed tests: 985
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInstance_nictype_update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeInstance_nictype_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[SirGitsalot]

Looks good, just need to revert the test change. Thanks!

[SirGitsalot]

The test is failing because this config uses an e2-medium instance and IDPF is only supported on bare metal instances, the smallest of which is c3-standard-192-metal. Since this is just an enum value rather than a new field I'm OK with reverting the test addition - spinning up an instance of this size regularly is likely to cause us quota headaches in the future.

[Asiderr]

Fully agree, I reverted the test and I rebased changes on top of the current main.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 6 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 4 files changed, 6 insertions(+), 6 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  network_interface {
    nic_type = # value needed
  }
}

Resource: google_compute_instance_from_template (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  network_interface {
    nic_type = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 1060
Passed tests: 987
Skipped tests: 73
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log