Add performance config field to Filestore instance

[yaelbarak]

Performance configuration support for Filestore.

Release Note Template for Downstream PRs (will be copied)

filestore: added `performance_config` field to `google_filestore_instance`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 380 insertions(+))
google-beta provider: Diff ( 3 files changed, 380 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 78 insertions(+))

[modular-magician]

Tests analytics

Total tests: 13
Passed tests: 12
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreInstance_performanceConfig

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccFilestoreInstance_performanceConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 380 insertions(+))
google-beta provider: Diff ( 3 files changed, 380 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 78 insertions(+))

[modular-magician]

Tests analytics

Total tests: 13
Passed tests: 12
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreInstance_performanceConfig

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccFilestoreInstance_performanceConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[SarahFrench]

Hi, thanks for your PR!

The test failure reported here fails with this error:

Error: Error creating Instance: googleapi: Error 400: ConfigurablePerformance is disabled

Do you know if this is a feature that needs to be opted-into at a project level?

[yaelbarak]

@SarahFrench yes, there's an experiment guarding this feature. I submitted a CL adding Terraform projects to the allowlist of the experiment, this will enable the tests to run. I'm curretnly waiting for the rollout of the experiments allowlist and once it's done I will rerun the tests.

[yaelbarak]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 380 insertions(+))
google-beta provider: Diff ( 3 files changed, 380 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 78 insertions(+))

[modular-magician]

Tests analytics

Total tests: 13
Passed tests: 12
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreInstance_performanceConfig

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccFilestoreInstance_performanceConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[yaelbarak]

@SarahFrench The Terraform projects are now allowlisted for the feature guarding experiment. I reran the tests and they're now passing.

[SarahFrench]

Thanks for resolving the testing issues!

There isn't any public documentation I can cross-reference with during review, but I'm happy to approve based on the acceptance tests