-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GKE Parallelstore CSI Driver Terraform Integration #12147
GKE Parallelstore CSI Driver Terraform Integration #12147
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR. View the build log |
Looks like ParallelstoreCsiDriverConfig was added in v0.203.0: googleapis/google-api-go-client@c77b5f4 But https://github.com/hashicorp/terraform-provider-google-beta/blob/main/go.mod#L35 is using v0.201.0 I manually edited the providers to use the v0.203.0 for all my testing so we might need to wait before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind leave this as a draft PR
and re-open it when we don't need to wait for anything else?
Created a PR to add the go.mod dependencies: #12188 |
f232989
to
fc7c696
Compare
#12188 is merged. |
Tests analyticsTotal tests: 215 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Hello @hao-nan-li, I merged the missing dependency. All tests are passing now. Could you please take a look now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the changelog based on https://googlecloudplatform.github.io/magic-modules/contribute/release-notes/?
I don't think GKE
is the correct name for the product.
@hao-nan-li GKE is the same product name used in which is the same change as this PR, but for the GCS FUSE CSI Driver: #7884 Do you have a better sugestion about the name of the product? |
I think it should be |
This PR is to add terraform support for running GKE Parallelstore as CSI driver for GKE cluster.
If this PR is for Terraform, I acknowledge that I have:
Reference PR: #7884
Issue: hashicorp/terraform-provider-google#18366
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.