Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GKE Parallelstore CSI Driver Terraform Integration #12147

Merged

Conversation

uriel-guzman
Copy link
Contributor

@uriel-guzman uriel-guzman commented Oct 26, 2024

This PR is to add terraform support for running GKE Parallelstore as CSI driver for GKE cluster.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Reference PR: #7884
Issue: hashicorp/terraform-provider-google#18366

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: added `parallelstore_csi_driver_config` field to `google_container_cluster` resource.

@github-actions github-actions bot requested a review from hao-nan-li October 26, 2024 02:08
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 43 insertions(+))
google-beta provider: Diff ( 3 files changed, 43 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • container

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@uriel-guzman
Copy link
Contributor Author

uriel-guzman commented Oct 26, 2024

Looks like ParallelstoreCsiDriverConfig was added in v0.203.0: googleapis/google-api-go-client@c77b5f4

But https://github.com/hashicorp/terraform-provider-google-beta/blob/main/go.mod#L35 is using v0.201.0

I manually edited the providers to use the v0.203.0 for all my testing so we might need to wait before merging.

Copy link
Contributor

@hao-nan-li hao-nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind leave this as a draft PR and re-open it when we don't need to wait for anything else?

@uriel-guzman
Copy link
Contributor Author

Created a PR to add the go.mod dependencies: #12188

@uriel-guzman
Copy link
Contributor Author

#12188 is merged.

@uriel-guzman uriel-guzman marked this pull request as ready for review October 30, 2024 18:35
@github-actions github-actions bot requested a review from hao-nan-li October 30, 2024 18:36
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 43 insertions(+))
google-beta provider: Diff ( 3 files changed, 43 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 215
Passed tests: 201
Skipped tests: 13
Affected tests: 1

Click here to see the affected service packages
  • container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerCluster_withAddons

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_withAddons [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@uriel-guzman
Copy link
Contributor Author

Hello @hao-nan-li, I merged the missing dependency. All tests are passing now. Could you please take a look now.

Copy link
Contributor

@hao-nan-li hao-nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the changelog based on https://googlecloudplatform.github.io/magic-modules/contribute/release-notes/?

I don't think GKE is the correct name for the product.

@uriel-guzman
Copy link
Contributor Author

uriel-guzman commented Nov 1, 2024

@hao-nan-li GKE is the same product name used in which is the same change as this PR, but for the GCS FUSE CSI Driver: #7884

Do you have a better sugestion about the name of the product?

@hao-nan-li
Copy link
Contributor

@hao-nan-li GKE is the same product name used in which is the same change as this PR, but for the GCS FUSE CSI Driver: #7884

Do you have a better sugestion about the name of the product?

I think it should be container, I'll update the note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants