refactor: update resource manager tag references #12118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the code for go tests to use `foo.id` vs `"tagKeys/${foo.name}"`
or `"tagValues/${foo.name}"`, and `foo.namespaced_name` vs.
`"${data.google_project.project.project_id}/${foo.short_name}"`
Part 1: can update generated resources separately, and container_cluster
is already covered in other PRs.
Wrap map keys in parens where needed.
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
modular-magician
added
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1207 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
wyardley
commented
Oct 24, 2024
| @@ -4324,8 +4324,8 @@ resource "google_bigquery_table" "test" { | |||
| dataset_id = "${google_bigquery_dataset.test.dataset_id}" | |||
| table_id = "%{table_id}" | |||
| resource_tags = { | |||
| "%{project_id}/${google_tags_tag_key.key1.short_name}" = "${google_tags_tag_value.value1.short_name}" | |||
| "%{project_id}/${google_tags_tag_key.key2.short_name}" = "${google_tags_tag_value.value2.short_name}" | |||
| (google_tags_tag_key.key1.namespaced_name) = google_tags_tag_value.value1.short_name | |||
There was a problem hiding this comment.
note: for these namespaced_name / short_name pairs, I _suspectthey would work with.id` on both side like in the other examples, but this makes the adjustments more minimal, as I believe it should be exactly equivalent with the old value.
If someone has a strong opinion about which is correct, they could easily be updated.
slevenick
approved these changes
Oct 25, 2024
This was referenced Oct 25, 2024
wyardley
added a commit
to wyardley/magic-modules
that referenced
this pull request
Oct 25, 2024
Update resource manager tag references in formatting Followup to GoogleCloudPlatform#12118
wyardley
added a commit
to wyardley/magic-modules
that referenced
this pull request
Oct 25, 2024
Update resource manager tag references in terraform code templates and
some minor formatting changes
- Update the code to use foo.id vs "tagKeys/${foo.name}" or
"tagValues/${foo.name}", and foo.namespaced_name vs.
"${data.google_project.project.project_id}/${foo.short_name}"
- Wrap map keys in parens where needed.
Followup to GoogleCloudPlatform#12118
wyardley
added a commit
to wyardley/magic-modules
that referenced
this pull request
Oct 25, 2024
Update resource manager tag references in terraform code templates and
some minor formatting changes
- Update the code to use foo.id vs "tagKeys/${foo.name}" or
"tagValues/${foo.name}", and foo.namespaced_name vs.
"${data.google_project.project.project_id}/${foo.short_name}"
- Wrap map keys in parens where needed.
Followup to GoogleCloudPlatform#12118
wyardley
added a commit
to wyardley/magic-modules
that referenced
this pull request
Oct 29, 2024
Update resource manager tag references in terraform code templates and
some minor formatting changes
- Update the code to use foo.id vs "tagKeys/${foo.name}" or
"tagValues/${foo.name}", and foo.namespaced_name vs.
"${data.google_project.project.project_id}/${foo.short_name}"
- Wrap map keys in parens where needed.
Followup to GoogleCloudPlatform#12118
This was referenced Oct 31, 2024
BBBmau
pushed a commit
to BBBmau/magic-modules
that referenced
this pull request
Nov 5, 2024
akshat-jindal-nit
pushed a commit
to akshat-jindal-nit/magic-modules
that referenced
this pull request
Nov 18, 2024
amanMahendroo
pushed a commit
to amanMahendroo/magic-modules
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the code for handwritten / templated go tests to use
foo.idvs"tagKeys/${foo.name}"or"tagValues/${foo.name}", andfoo.namespaced_namevs."${data.google_project.project.project_id}/${foo.short_name}"This would be part 1: can update the resources for generated resources separately, and container_cluster will be covered in a separate PR.
Wrap map keys in parens where needed.
I tried to adjust spacing only in the affected blocks vs. doing any other terraform reformatting, except in one or two extreme cases.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.