Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating template check for go templates #12097

Merged
merged 11 commits into from
Oct 30, 2024
Merged

Updating template check for go templates #12097

merged 11 commits into from
Oct 30, 2024

Conversation

NickElliot
Copy link
Contributor

@NickElliot NickElliot commented Oct 22, 2024 •
edited
Loading

Interim step before removing all ruby files
pending #11958 merge

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@NickElliot NickElliot requested a review from c2thorn October 24, 2024 21:51
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

c2thorn
c2thorn approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickElliot NickElliot merged commit c6b993c into GoogleCloudPlatform:main Oct 30, 2024
16 checks passed
This was referenced Oct 30, 2024
Merged
Merged
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Nov 1, 2024
@NickElliot @niharika-98
Updating template check for go templates (GoogleCloudPlatform#12097)
9211041
@NickElliot NickElliot mentioned this pull request Nov 4, 2024
Open
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
@NickElliot @BBBmau
Updating template check for go templates (GoogleCloudPlatform#12097)
b477589
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
@NickElliot @akshat-jindal-nit
Updating template check for go templates (GoogleCloudPlatform#12097)
8298079
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
@NickElliot @amanMahendroo
Updating template check for go templates (GoogleCloudPlatform#12097)
aec564f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c2thorn c2thorn c2thorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NickElliot @modular-magician @c2thorn