Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to fix incorrect timeout value in google_composer_environment #12080

Merged

Conversation

entertvl
Copy link
Contributor

@entertvl entertvl commented Oct 22, 2024

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

composer: fixed documentation of `google_composer_environment` timeouts

Referenced code for the correct value:
https://github.com/entertvl/magic-modules/blob/7d347c6f24461fdb48798926aa50c6a96da068eb/mmv1/third_party/terraform/services/composer/resource_composer_environment.go.tmpl#L161-L166

Related PR:
#2863

@github-actions github-actions bot requested a review from SirGitsalot October 22, 2024 07:21
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 22, 2024
@SirGitsalot
Copy link
Member

/gcbrun

@modular-magician modular-magician added service/composer and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Oct 22, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))

Copy link
Member

@SirGitsalot SirGitsalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@SirGitsalot SirGitsalot merged commit b6192e2 into GoogleCloudPlatform:main Oct 22, 2024
11 of 12 checks passed
@entertvl entertvl deleted the fix-composer-environment-docs branch October 23, 2024 02:44
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
Spheny1 pushed a commit to Spheny1/magic-modules that referenced this pull request Nov 13, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants